Skip to content

enable pnv-phb user created devices

Daniel Henrique Barboza qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ppc/pnv: add phb-id/chip-id PnvPHB3RootBus propertieshw/pci-host/pnv_phb3.c include/hw/pci-host/pnv_phb3.h+58 -10 replies
2/10ppc/pnv: add phb-id/chip-id PnvPHB4RootBus propertieshw/pci-host/pnv_phb4.c include/hw/pci-host/pnv_phb4.h+61 -00 replies
3/10ppc/pnv: set root port chassis and slot using Bus propertieshw/pci-host/pnv_phb.c+16 -90 replies
4/10ppc/pnv: add helpers for pnv-phb user deviceshw/pci-host/pnv_phb.c+69 -00 replies
5/10ppc/pnv: turn chip8->phbs[] into a PnvPHB* arrayhw/pci-host/pnv_phb.c hw/ppc/pnv.c include/hw/ppc/pnv.h+31 -60 replies
6/10ppc/pnv: enable user created pnv-phb for powernv8hw/pci-host/pnv_phb.c hw/ppc/pnv.c+13 -20 replies
7/10ppc/pnv: add PHB4 helpers for user created pnv-phbhw/pci-host/pnv_phb.c+39 -00 replies
8/10ppc/pnv: enable user created pnv-phb powernv9hw/pci-host/pnv_phb.c hw/pci-host/pnv_phb4_pec.c hw/ppc/pnv.c+7 -30 replies
9/10ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecshw/pci-host/pnv_phb.c+15 -20 replies
10/10ppc/pnv: user creatable pnv-phb for powernv10hw/ppc/pnv.c+2 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/10] enable pnv-phb user created devices

This series is built on top of

"[PATCH v3 00/12] powernv: introduce pnv-phb base/proxy devices" [1]

that is under review in [1]. I'm sending this last part of the pnv-phb rework to allow everyone to see what's the endgame I'm planning with this work.

The main differences between the approach taken here, versus the approach made by "[PATCH v2 00/16] powernv: introduce pnv-phb base/proxy devices" [2], is:

- the Root Buses objects are now inheriting phb-id and chip-id. This turned out to be a clean way of keeping the code QOM compliant, without having to do things like dev->parent_bus->parent. All the attributes that the root port needs are found in its bus parent;

- the logic exclusive to user created devices is all centered in a single helper inside pnv-phb realize(). PHB3/PHB4 realize() are oblivious to whether the device is user created or not. I believe this approach is clearer than what I was doing before.

I'll respin/rebase this patches depending on the amount of changes we have during the pnv-phb proxy device review.

[1] https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg04347.html
[2] https://lists.gnu.org/archive/html/qemu-devel/2022-05/msg06254.html

Daniel Henrique Barboza (10):
ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties ppc/pnv: set root port chassis and slot using Bus properties ppc/pnv: add helpers for pnv-phb user devices ppc/pnv: turn chip8->phbs[] into a PnvPHB* array ppc/pnv: enable user created pnv-phb for powernv8 ppc/pnv: add PHB4 helpers for user created pnv-phb ppc/pnv: enable user created pnv-phb powernv9 ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecs ppc/pnv: user creatable pnv-phb for powernv10

 hw/pci-host/pnv_phb.c          | 166 ++++++++++++++++++++++++++++++---
 hw/pci-host/pnv_phb3.c         |  50 ++++++++++
 hw/pci-host/pnv_phb4.c         |  51 ++++++++++
 hw/pci-host/pnv_phb4_pec.c     |   6 +-
 hw/ppc/pnv.c                   |  30 +++++-
 include/hw/pci-host/pnv_phb3.h |   9 +-
 include/hw/pci-host/pnv_phb4.h |  10 ++
 include/hw/ppc/pnv.h           |   6 +-
 8 files changed, 308 insertions(+), 20 deletions(-)
Signature · 1 line
2.36.1