Skip to content

can: kvaser_usb: CAN clock frequency regression

Jimmy Assarsson linux-can stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4can: kvaser_usb: Add struct kvaser_usb_dev_cfgdrivers/net/can/usb/kvaser_usb.c+52 -241 reply
2/4can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_infodrivers/net/can/usb/kvaser_usb.c+93 -820 replies
3/4can: kvaser_usb: fix CAN clock frequency regressiondrivers/net/can/usb/kvaser_usb.c+35 -180 replies
4/4can: kvaser_usb: fix bittiming limitsdrivers/net/can/usb/kvaser_usb.c+54 -330 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 4.9 0/4] can: kvaser_usb: CAN clock frequency regression

Backport of upstream patch series [1].

Note: The patch "[PATCH 4.9 1/4] can: kvaser_usb: Add struct kvaser_usb_dev_cfg"
is added for this backport, and was not part of the original series.

When fixing the CAN clock frequency,
fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"), I introduced a regression.

For Leaf devices based on M32C, the firmware expects bittiming parameters calculated for 16MHz clock. Regardless of the actual clock frequency.

This regression affects M32C based Leaf devices with non-16MHz clock.

Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits are different depending on which firmware/device being used.

[1]
https://lore.kernel.org/linux-can/[email protected]/

Jimmy Assarsson (4):
can: kvaser_usb: Add struct kvaser_usb_dev_cfg
can: kvaser_usb: replace run-time checks with struct
kvaser_usb_driver_info
can: kvaser_usb: fix CAN clock frequency regression
can: kvaser_usb: fix bittiming limits

 drivers/net/can/usb/kvaser_usb.c | 325 +++++++++++++++++++------------
 1 file changed, 201 insertions(+), 124 deletions(-)
Signature · 1 line
2.36.1