Skip to content

can: kvaser_usb: CAN clock frequency regression

Jimmy Assarsson linux-can stable 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3can: kvaser_usb: replace run-time checks with struct kvaser_usb_driver_infodrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+173 -1480 replies
2/3can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regressiondrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_core.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+38 -210 replies
3/3can: kvaser_usb: kvaser_usb_leaf: fix bittiming limitsdrivers/net/can/usb/kvaser_usb/kvaser_usb.h drivers/net/can/usb/kvaser_usb/kvaser_usb_hydra.c drivers/net/can/usb/kvaser_usb/kvaser_usb_leaf.c+47 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 5.15 0/3] can: kvaser_usb: CAN clock frequency regression

Backport of upstream patch series [1].

When fixing the CAN clock frequency,
fb12797ab1fe ("can: kvaser_usb: get CAN clock frequency from device"), I introduced a regression.

For Leaf devices based on M32C, the firmware expects bittiming parameters calculated for 16MHz clock. Regardless of the actual clock frequency.

This regression affects M32C based Leaf devices with non-16MHz clock.

Also correct the bittiming constants in kvaser_usb_leaf.c, where the limits are different depending on which firmware/device being used.

[1]
https://lore.kernel.org/linux-can/[email protected]/

Jimmy Assarsson (3):
can: kvaser_usb: replace run-time checks with struct
kvaser_usb_driver_info
can: kvaser_usb: kvaser_usb_leaf: fix CAN clock frequency regression
can: kvaser_usb: kvaser_usb_leaf: fix bittiming limits

 drivers/net/can/usb/kvaser_usb/kvaser_usb.h   |  25 +-
 .../net/can/usb/kvaser_usb/kvaser_usb_core.c  | 286 ++++++++++--------
 .../net/can/usb/kvaser_usb/kvaser_usb_hydra.c |   4 +-
 .../net/can/usb/kvaser_usb/kvaser_usb_leaf.c  | 119 ++++----
 4 files changed, 244 insertions(+), 190 deletions(-)
Signature · 1 line
2.36.1