Skip to content

staging: qlge: code refinement around a for loop

Binyi Han linux-staging lkml netdev 4 versions – New

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 0 repliesNew
  2. v31 patch 9 repliesSuperseded
  3. v21 patch 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch2 repliesSuperseded

Changes in v4 from the cover letter

- Separate the code style change and "optimization" into 2 patches

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2staging: qlge: Fix indentation issue under long for loopdrivers/staging/qlge/qlge_main.c+10 -80 replies
2/2staging: qlge: Avoid multiplication while keep the same logicdrivers/staging/qlge/qlge_main.c+8 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/2] staging: qlge: code refinement around a for loop

* Patch 1:
Fix indentation according to checkpatch. Format the long for loop thanks to Joe's review.
* Patch 2:
Optimize by avoiding the multiplication thanks to Joe's review.
I agree with Joe and think it's the same logic, and it compiles without error.
But I don't have the real hardware, so can't prove that code is still doing the same thing. So I understand if you don't apply this patch without the "proof".

v4:
- Separate the code style change and "optimization" into 2 patches
v3:
Thanks to Joe's review.
- Align page_entries in the for loop to open parenthesis.
- Optimize by avoiding the multiplication.
v2:
- Change the long for loop into 3 lines

Binyi Han (2):
staging: qlge: Fix indentation issue under long for loop
staging: qlge: Avoid multiplication while keep the same logic

 drivers/staging/qlge/qlge_main.c | 20 ++++++++++++--------
 1 file changed, 12 insertions(+), 8 deletions(-)
Signature · 1 line
2.25.1