mlx5 devlink mutex removal part 1
Status from this message: This series was applied to netdev/net-next.git (master)
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 All 9 applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | net/mlx5: Remove devl_unlock from mlx5_eswtich_mode_callback_enterdrivers/ | +11 | 0 replies | Applied |
| 2/9 | net/mlx5: Use devl_ API for rate nodes destroydrivers/ drivers/ | +14 | 0 replies | Applied |
| 3/9 | devlink: Remove unused function devlink_rate_nodes_destroyinclude/ net/ | +0 | 0 replies | Applied |
| 4/9 | net/mlx5: Use devl_ API in mlx5_esw_offloads_devlink_port_registerdrivers/ drivers/ drivers/ | +19 | 0 replies | Applied |
| 5/9 | net/mlx5: Use devl_ API in mlx5_esw_devlink_sf_port_registerdrivers/ drivers/ | +9 | 0 replies | Applied |
| 6/9 | devlink: Remove unused functions devlink_rate_leaf_create/destroyinclude/ net/ | +7 | 0 replies | Applied |
| 7/9 | net/mlx5: Use devl_ API in mlx5e_devlink_port_registerdrivers/ drivers/ drivers/ +1 more | +47 | 0 replies | Applied |
| 8/9 | net/mlx5: Remove devl_unlock from mlx5_devlink_eswitch_mode_setdrivers/ | +0 | 0 replies | Applied |
| 9/9 | devlink: Hold the instance lock in port_new / port_del callbacksdrivers/ net/ | +1 | 0 replies | Applied |
Reviews trailers per patch
8 of 9 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Leon Romanovsky | Jakub Kicinski |
|---|---|---|
| Series | A-b | |
| 1/9 | R-b | |
| 2/9 | R-b | |
| 3/9 | R-b | |
| 4/9 | R-b | |
| 5/9 | R-b | |
| 6/9 | R-b | |
| 7/9 | ||
| 8/9 | R-b | |
| 9/9 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH net-next 0/9] mlx5 devlink mutex removal part 1
From: Saeed Mahameed <[email protected]>
Moshe Shemesh Says:
===================
1) Fix devlink lock in mlx5 devlink eswitch callbacks
Following the commit 14e426bf1a4d "devlink: hold the instance lock during eswitch_mode callbacks" which takes devlink instance lock for all devlink eswitch callbacks and adds a temporary workaround, this patchset removes the workaround, replaces devlink API functions by devl_ API where called from mlx5 driver eswitch callbacks flows and adds devlink instance lock in other driver's path that leads to these functions. While moving to devl_ API the patchset removes part of the devlink API functions which mlx5 was the last one to use and so not used by any driver now.
The patchset also remove DEVLINK_NL_FLAG_NO_LOCK flag from the callbacks of port_new/port which are called only from mlx5 driver and the already locked by the patchset as parallel paths to the eswitch callbacks using devl_ API functions.
This patchset will be followed by another patchset that will remove DEVLINK_NL_FLAG_NO_LOCK flag from devlink reload and devlink health callbacks. Thus we will have all devlink callbacks locked and it will pave the way to remove devlink mutex.
===================
Moshe Shemesh (9):
net/mlx5: Remove devl_unlock from mlx5_eswtich_mode_callback_enter net/mlx5: Use devl_ API for rate nodes destroy
devlink: Remove unused function devlink_rate_nodes_destroy net/mlx5: Use devl_ API in mlx5_esw_offloads_devlink_port_register net/mlx5: Use devl_ API in mlx5_esw_devlink_sf_port_register
devlink: Remove unused functions devlink_rate_leaf_create/destroy net/mlx5: Use devl_ API in mlx5e_devlink_port_register net/mlx5: Remove devl_unlock from mlx5_devlink_eswitch_mode_set
devlink: Hold the instance lock in port_new / port_del callbacks
drivers/net/ethernet/mellanox/mlx5/core/dev.c | 29 +++++++- .../ethernet/mellanox/mlx5/core/en/devlink.c | 16 ++++- .../mellanox/mlx5/core/esw/devlink_port.c | 20 +++--- .../net/ethernet/mellanox/mlx5/core/eswitch.c | 18 ++++- .../mellanox/mlx5/core/eswitch_offloads.c | 57 +++++----------- include/linux/mlx5/driver.h | 4 ++ include/net/devlink.h | 3 - net/core/devlink.c | 66 +++---------------- 8 files changed, 94 insertions(+), 119 deletions(-)
Signature · 1 line
2.36.1