Skip to content

sysctl: Fix data-races around ipv4_net_table (Round 1).

Kuniyuki Iwashima lkml netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesApplied 15/15

Patches in v1 All 15 applied

#Subject and filesSizeRepliesApplied
1/15sysctl: Fix data-races in proc_dou8vec_minmax().kernel/sysctl.c+2 -20 repliesApplied
2/15sysctl: Fix data-races in proc_dointvec_ms_jiffies().kernel/sysctl.c+4 -40 repliesApplied
3/15tcp: Fix a data-race around sysctl_max_tw_buckets.net/ipv4/inet_timewait_sock.c+2 -10 repliesApplied
4/15icmp: Fix a data-race around sysctl_icmp_echo_ignore_all.net/ipv4/icmp.c net/ipv4/sysctl_net_ipv4.c+3 -10 repliesApplied
5/15icmp: Fix data-races around sysctl_icmp_echo_enable_probe.net/ipv4/icmp.c net/ipv6/icmp.c+2 -20 repliesApplied
6/15icmp: Fix a data-race around sysctl_icmp_echo_ignore_broadcasts.net/ipv4/icmp.c net/ipv4/sysctl_net_ipv4.c+3 -10 repliesApplied
7/15icmp: Fix a data-race around sysctl_icmp_ignore_bogus_error_responses.net/ipv4/icmp.c net/ipv4/sysctl_net_ipv4.c+3 -10 repliesApplied
8/15icmp: Fix a data-race around sysctl_icmp_errors_use_inbound_ifaddr.net/ipv4/icmp.c net/ipv4/sysctl_net_ipv4.c+3 -10 repliesApplied
9/15icmp: Fix a data-race around sysctl_icmp_ratelimit.net/ipv4/icmp.c+2 -10 repliesApplied
10/15icmp: Fix a data-race around sysctl_icmp_ratemask.net/ipv4/icmp.c+1 -10 repliesApplied
11/15raw: Fix a data-race around sysctl_raw_l3mdev_accept.include/net/raw.h+1 -10 repliesApplied
12/15tcp: Fix data-races around sysctl_tcp_ecn.drivers/net/ethernet/chelsio/inline_crypto/chtls/chtls_cm.c net/ipv4/syncookies.c net/ipv4/sysctl_net_ipv4.c +2 more+6 -40 repliesApplied
13/15tcp: Fix a data-race around sysctl_tcp_ecn_fallback.net/ipv4/sysctl_net_ipv4.c net/ipv4/tcp_output.c+3 -10 repliesApplied
14/15ipv4: Fix data-races around sysctl_ip_dynaddr.Documentation/networking/ip-sysctl.rst net/ipv4/af_inet.c+3 -30 repliesApplied
15/15nexthop: Fix data-races around nexthop_compat_mode.net/ipv4/fib_semantics.c net/ipv4/nexthop.c net/ipv6/route.c+5 -40 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 1).

This series fixes data-races around the first 13 knobs and nexthop_compat_mode in ipv4_net_table.

I will post another patch for three early_demux knobs later, so the next round will start from ip_default_ttl.

Kuniyuki Iwashima (15):
sysctl: Fix data-races in proc_dou8vec_minmax().
sysctl: Fix data-races in proc_dointvec_ms_jiffies().
tcp: Fix a data-race around sysctl_max_tw_buckets.
icmp: Fix a data-race around sysctl_icmp_echo_ignore_all.
icmp: Fix data-races around sysctl_icmp_echo_enable_probe.
icmp: Fix a data-race around sysctl_icmp_echo_ignore_broadcasts.
icmp: Fix a data-race around sysctl_icmp_ignore_bogus_error_responses.
icmp: Fix a data-race around sysctl_icmp_errors_use_inbound_ifaddr.
icmp: Fix a data-race around sysctl_icmp_ratelimit.
icmp: Fix a data-race around sysctl_icmp_ratemask.

  raw: Fix a data-race around sysctl_raw_l3mdev_accept.
  tcp: Fix data-races around sysctl_tcp_ecn.
  tcp: Fix a data-race around sysctl_tcp_ecn_fallback.
  ipv4: Fix data-races around sysctl_ip_dynaddr.
  nexthop: Fix data-races around nexthop_compat_mode.
 Documentation/networking/ip-sysctl.rst            |  2 +-
 .../chelsio/inline_crypto/chtls/chtls_cm.c        |  2 +-
 include/net/raw.h                                 |  2 +-
 kernel/sysctl.c                                   | 12 ++++++------
 net/ipv4/af_inet.c                                |  4 ++--
 net/ipv4/fib_semantics.c                          |  2 +-
 net/ipv4/icmp.c                                   | 15 ++++++++-------
 net/ipv4/inet_timewait_sock.c                     |  3 ++-
 net/ipv4/nexthop.c                                |  5 +++--
 net/ipv4/syncookies.c                             |  2 +-
 net/ipv4/sysctl_net_ipv4.c                        | 12 ++++++++++++
 net/ipv4/tcp_input.c                              |  2 +-
 net/ipv4/tcp_output.c                             |  4 ++--
 net/ipv6/icmp.c                                   |  2 +-
 net/ipv6/route.c                                  |  2 +-
 15 files changed, 43 insertions(+), 28 deletions(-)
Signature · 1 line
2.30.2