ASoC: SOF: Intel: Do not process IPC reply before firmware boot
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware bootsound/ | +24 | 0 replies | |
| 2/3 | ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware bootsound/ | +25 | 0 replies | |
| 3/3 | ASoC: SOF: Intel: mtl: Do not process IPC reply before firmware bootsound/ | +13 | 0 replies |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Ranjani Sridharan | Pierre-Louis Bossart |
|---|---|---|
| 1/3 | R-b | R-b |
| 2/3 | R-b | R-b |
| 3/3 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/3] ASoC: SOF: Intel: Do not process IPC reply before firmware boot
Hi,
By mistake a developer managed to create a 'corrupted' IPC4 firmware image which loaded fine to the DSP and after boot it sent an IPC reply before we would have received the FW_READY message.
It turned out that the image was an IPC3 firmware and the IPC reply was the IPC3 FW_READY notification message which got understood as an IPC4 reply message due to the difference between the two IPC mechanism.
This caused a NULL pointer dereference since the reply memory will be allocated after the FW_READY message.
To make sure this will not bite again, skip any spurious reply messages before the FW_READY.
Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware boot
ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware
boot
ASoC: SOF: Intel: mtl: Do not process IPC reply before firmware boot
sound/soc/sof/intel/cnl.c | 37 +++++++++++++++++++++------------ sound/soc/sof/intel/hda-ipc.c | 39 ++++++++++++++++++++++------------- sound/soc/sof/intel/mtl.c | 20 +++++++++++------- 3 files changed, 62 insertions(+), 34 deletions(-)
Signature · 1 line
2.37.0