Skip to content

ASoC: SOF: Intel: Do not process IPC reply before firmware boot

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware bootsound/soc/sof/intel/cnl.c+24 -130 replies
2/3ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware bootsound/soc/sof/intel/hda-ipc.c+25 -140 replies
3/3ASoC: SOF: Intel: mtl: Do not process IPC reply before firmware bootsound/soc/sof/intel/mtl.c+13 -70 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchRanjani SridharanPierre-Louis Bossart
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/3] ASoC: SOF: Intel: Do not process IPC reply before firmware boot

Hi,

By mistake a developer managed to create a 'corrupted' IPC4 firmware image which loaded fine to the DSP and after boot it sent an IPC reply before we would have received the FW_READY message.
It turned out that the image was an IPC3 firmware and the IPC reply was the IPC3 FW_READY notification message which got understood as an IPC4 reply message due to the difference between the two IPC mechanism.

This caused a NULL pointer dereference since the reply memory will be allocated after the FW_READY message.

To make sure this will not bite again, skip any spurious reply messages before the FW_READY.

Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware boot
ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware
boot
ASoC: SOF: Intel: mtl: Do not process IPC reply before firmware boot

 sound/soc/sof/intel/cnl.c     | 37 +++++++++++++++++++++------------
 sound/soc/sof/intel/hda-ipc.c | 39 ++++++++++++++++++++++-------------
 sound/soc/sof/intel/mtl.c     | 20 +++++++++++-------
 3 files changed, 62 insertions(+), 34 deletions(-)
Signature · 1 line
2.37.0