Skip to content

ASoC: SOF: Intel: hda: Correct Firmware State Register use

Peter Ujfalusi alsa-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3ASoC: SOF: Intel: hda: Correct the ROM/FW state reporting codesound/soc/sof/intel/hda.c sound/soc/sof/intel/hda.h+190 -200 replies
2/3ASoC: SOF: Intel: hda-loader: Use the FSR state definitions during bootupsound/soc/sof/intel/hda-loader.c+4 -60 replies
3/3ASoC: SOF: Intel: hda: Drop no longer used ROM state definitionssound/soc/sof/intel/hda.h+0 -60 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchPierre-Louis BossartRander WangRanjani Sridharan
1/3R-b R-b R-b
2/3R-b R-b R-b
3/3R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/3] ASoC: SOF: Intel: hda: Correct Firmware State Register use

Hi,

The FSR (Firmware State Register) holds the ROM state information, it does not contain error information.
The FSR itself is a bit more complicated as well as the state depends on the module currently in use.

The error code from ROM or the status code from the firmware is located at the next register.

Fix the handling of the FSR in order to provide usable and human readable (in most cases) report on the status and error.

Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: SOF: Intel: hda: Correct the ROM/FW state reporting code
ASoC: SOF: Intel: hda-loader: Use the FSR state definitions during
bootup
ASoC: SOF: Intel: hda: Drop no longer used ROM state definitions

 sound/soc/sof/intel/hda-loader.c |  10 +--
 sound/soc/sof/intel/hda.c        | 147 ++++++++++++++++++++++++++-----
 sound/soc/sof/intel/hda.h        |  69 +++++++++++++--
 3 files changed, 194 insertions(+), 32 deletions(-)
Signature · 1 line
2.37.0