Skip to content

QOM'ify PIIX3 southbridge

Bernhard Beschow qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11hw/i386/pc: QOM'ify DMA creationhw/i386/pc.c hw/i386/pc_piix.c hw/isa/lpc_ich9.c +1 more+12 -50 replies
2/11hw/i386/pc_piix: Allow for setting properties before realizing PIIX3 southbridgehw/i386/pc_piix.c+2 -11 reply
3/11hw/isa/piix3: QOM'ify USB controller creationhw/i386/pc_piix.c hw/isa/piix3.c include/hw/southbridge/piix.h+33 -41 reply
4/11hw/isa/piix3: QOM'ify ACPI controller creationhw/i386/pc_piix.c hw/isa/piix3.c include/hw/southbridge/piix.h+31 -100 replies
5/11hw/i386/pc: QOM'ify RTC creationhw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +4 more+38 -20 replies
6/11hw/i386/pc: No need for rtc_state to be an out-parameterhw/i386/pc.c hw/i386/pc_piix.c hw/i386/pc_q35.c +1 more+7 -71 reply
7/11hw/intc/i8259: Introduce i8259 proxy "isa-pic"hw/intc/i8259.c include/hw/intc/i8259.h+41 -00 replies
8/11hw/isa/piix3: QOM'ify ISA PIC creationhw/i386/pc_piix.c hw/isa/piix3.c include/hw/southbridge/piix.h+20 -90 replies
9/11hw/isa/piix3: QOM'ify IDE controller creationhw/i386/Kconfig hw/i386/pc_piix.c hw/isa/Kconfig +2 more+16 -90 replies
10/11hw/isa/piix3: Wire up ACPI interrupt internallyhw/i386/pc_piix.c hw/isa/piix3.c+2 -10 replies
11/11hw/isa/piix3: Remove extra ';' outside of functionshw/isa/piix3.c+3 -31 reply

Reviews trailers per patch

3 of 11 patches have a Reviewed-by or Acked-by.

PatchPeter Maydell
1/11
2/11R-b
3/11
4/11
5/11
6/11R-b
7/11
8/11
9/11
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/11] QOM'ify PIIX3 southbridge

Similar to PIIX4 this series QOM'ifies internal device creation for PIIX3. This reduces the delta between the implementations of PIIX3 and PIIX4 and therefore might allow to merge both implementations in the future.

There were two challenges in this series:

First, QEMU considers the ACPI and USB functions to be optional in PIIX3. When instantiating those with object_initialize_child(), they need to be unparented in the realize function to prevent an assertion (see respective commit messages).

Second, the PIC used to be instantiated outside of the southbridge while some sub functions require a PIC with populated qemu_irqs. This has been solved by introducing a proxy PIC which furthermore allows PIIX3 to be agnostic towards the virtualization technology used (KVM, TCG, Xen).

Testing done:
* make check
* make check-avocado
* Boot live CD:
* qemu-system-x86_64 -M pc -m 2G -accel kvm -cpu host -cdrom manjaro-kde-21.3.2-220704-linux515.iso
* qemu-system-x86_64 -M q35 -m 2G -accel kvm -cpu host -cdrom manjaro-kde-21.3.2-220704-linux515.iso

Bernhard Beschow (11):
hw/i386/pc: QOM'ify DMA creation
hw/i386/pc_piix: Allow for setting properties before realizing PIIX3
southbridge
hw/isa/piix3: QOM'ify USB controller creation hw/isa/piix3: QOM'ify ACPI controller creation hw/i386/pc: QOM'ify RTC creation
hw/i386/pc: No need for rtc_state to be an out-parameter hw/intc/i8259: Introduce i8259 proxy "isa-pic" hw/isa/piix3: QOM'ify ISA PIC creation
hw/isa/piix3: QOM'ify IDE controller creation hw/isa/piix3: Wire up ACPI interrupt internally hw/isa/piix3: Remove extra ';' outside of functions

 hw/i386/Kconfig               |  1 -
 hw/i386/pc.c                  | 17 ++++---
 hw/i386/pc_piix.c             | 70 ++++++++++++++++-------------
 hw/i386/pc_q35.c              |  3 +-
 hw/intc/i8259.c               | 27 +++++++++++
 hw/isa/Kconfig                |  1 +
 hw/isa/lpc_ich9.c             | 11 +++++
 hw/isa/piix3.c                | 84 ++++++++++++++++++++++++++++++++---
 include/hw/i386/ich9.h        |  2 +
 include/hw/i386/pc.h          |  2 +-
 include/hw/intc/i8259.h       | 14 ++++++
 include/hw/southbridge/piix.h | 16 ++++++-
 12 files changed, 201 insertions(+), 47 deletions(-)
Signature · 1 line
2.37.1