Skip to content

s390x: add tests for SIGP call orders in enabled wait

Nico Boehr kvm 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 5 repliesIn review
  2. v33 patches 4 repliesSuperseded
  3. v23 patches 4 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v14 patches0 repliesSuperseded

Changes in v4 from the cover letter

---
* uint32_t -> unsigned int for cr0_bit so it matches ctl_set/clear_bit argument (thanks Claudio)
* fix double interrupt not detected because ctl0 bit was cleared in the interrupt handler

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3s390x: smp: move sigp calls with invalid cpu address to arrays390x/smp.c+3 -151 reply
2/3s390x: smp: use an array for sigp callss390x/smp.c+48 -761 reply
3/3s390x: smp: add tests for calls in wait states390x/smp.c+97 -03 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchJanosch FrankClaudio Imbrenda
1/3R-b R-b
2/3R-b R-b
3/3R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [kvm-unit-tests PATCH v4 0/3] s390x: add tests for SIGP call orders in enabled wait

v3->v4:
---
* uint32_t -> unsigned int for cr0_bit so it matches ctl_set/clear_bit argument (thanks Claudio)
* fix double interrupt not detected because ctl0 bit was cleared in the interrupt handler

v2->v3:
---
* added some comments (thanks Janosch)
* fix bit-mask confusion (thanks Janosch)
* remove ctl_clear_bit() in call_in_wait_received() since it's handled in the interrupt cleanup already

v1->v2:
---
* rebase to latest master to align with Claudio's SMP changes, drop patch which adds the ext int clean up since it is already in Claudio's series
* make sure ctl0 register bit is cleared

When a CPU is in enabled wait, it can still receive SIGP calls from other CPUs.

Since this requires some special handling in KVM, we should have tests for it. This has already revealed a KVM bug with ecall under PV, which is why this test currently fails there.

Some refactoring is done as part of this series to reduce code duplication.

Nico Boehr (3):
s390x: smp: move sigp calls with invalid cpu address to array
s390x: smp: use an array for sigp calls
s390x: smp: add tests for calls in wait state

 s390x/smp.c | 217 +++++++++++++++++++++++++++++++++-------------------
 1 file changed, 137 insertions(+), 80 deletions(-)
Signature · 1 line
2.36.1