Skip to content

dump: Add arch section and s390x PV dump

Janosch Frank qemu-devel 5 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest10 patches 14 repliesIn review
  2. v518 patches 27 repliesSuperseded
  3. v417 patches 34 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v314 patches17 repliesSuperseded
v211 patches17 repliesSuperseded

Changes in v6 from the cover letter

* Rebase after parts of the series have been pulled
* Put the section header move into its own patch
* Added freeing of s->elf_section_hdrs
* Added missing false fields in the note arrays in arch_dump.c

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10dump: Use a buffer for ELF section data and headersdump/dump.c include/sysemu/dump.h+55 -261 reply
2/10dump: Write ELF section headers right after ELF headerdump/dump.c+14 -174 replies
3/10dump: Reorder struct DumpStateinclude/sysemu/dump.h+9 -70 replies
4/10dump: Reintroduce memory_offset and section_offsetdump/dump.c+2 -01 reply
5/10dump: Add architecture section and section string table supportdump/dump.c include/sysemu/dump-arch.h include/sysemu/dump.h+168 -282 replies
6/10s390x: Add protected dump captarget/s390x/kvm/kvm.c target/s390x/kvm/kvm_s390x.h+8 -00 replies
7/10s390x: Introduce PV query interfacehw/s390x/pv.c hw/s390x/s390-virtio-ccw.c include/hw/s390x/pv.h+77 -00 replies
8/10RFC: elf.h changesinclude/elf.h+2 -01 reply
9/10s390x: Add KVM PV dump interfacehw/s390x/pv.c include/hw/s390x/pv.h+60 -03 replies
10/10s390x: pv: Add dump supportdump/dump.c include/sysemu/dump.h target/s390x/arch_dump.c+246 -331 reply

Reviews trailers per patch

All 10 patches have a Reviewed-by or Acked-by.

PatchRichard HendersonMarc-André LureauSteffen EidenThomas HuthJanis Schoetterl-Glausch
1/10R-b
2/10R-b
3/10R-b R-b
4/10R-b
5/10R-b R-b
6/10R-b R-b R-b
7/10R-b A-b R-b
8/10R-b
9/10R-b R-b
10/10R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v6 thread

Cover letter [PATCH v6 00/10] dump: Add arch section and s390x PV dump

Previously this series was two separate series:
* Arch section support
Adds the possibility for arch code to add custom section data.

* s390 PV dump support
Adds PV dump data to the custom arch sections.

I've chosen to merge them so it's easier to understand why the arch section support has been implement the way it is.

Additionally I've added cleanup patches beforehand which clean up the GuestPhysBlock usage.

v6:
* Rebase after parts of the series have been pulled
* Put the section header move into its own patch
* Added freeing of s->elf_section_hdrs
* Added missing false fields in the note arrays in arch_dump.c

v5:
* Added a patch that moves the DumpState typedef and replaces the opaque pointers with properly typed ones
* Removed the ELF header allocation since the codes has changed in a way that it's not needed anymore
* Changed naming of dump_get_memblock_*() to dump_filter_memblock_*()
* Removed various inline functions
* Added a re-work of the filter variables

Janosch Frank (10):
dump: Use a buffer for ELF section data and headers
dump: Write ELF section headers right after ELF header
dump: Reorder struct DumpState
dump: Reintroduce memory_offset and section_offset
dump: Add architecture section and section string table support
s390x: Add protected dump cap
s390x: Introduce PV query interface
RFC: elf.h changes
s390x: Add KVM PV dump interface
s390x: pv: Add dump support

 dump/dump.c                  | 290 +++++++++++++++++++++++++++--------
 hw/s390x/pv.c                | 112 ++++++++++++++
 hw/s390x/s390-virtio-ccw.c   |   6 +
 include/elf.h                |   2 +
 include/hw/s390x/pv.h        |  19 +++
 include/sysemu/dump-arch.h   |   3 +
 include/sysemu/dump.h        |  26 +++-
 target/s390x/arch_dump.c     | 262 +++++++++++++++++++++++++++----
 target/s390x/kvm/kvm.c       |   7 +
 target/s390x/kvm/kvm_s390x.h |   1 +
 10 files changed, 629 insertions(+), 99 deletions(-)
Signature · 1 line
2.34.1