Skip to content

sysctl: Fix data-races around ipv4_net_table (Round 2).

Kuniyuki Iwashima netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 0 repliesApplied 15/15

Patches in v1 All 15 applied

#Subject and filesSizeRepliesApplied
1/15ip: Fix data-races around sysctl_ip_default_ttl.drivers/net/ethernet/netronome/nfp/flower/action.c include/net/route.h net/ipv4/ip_sockglue.c +3 more+7 -70 repliesApplied
2/15ip: Fix data-races around sysctl_ip_no_pmtu_disc.net/ipv4/af_inet.c net/ipv4/icmp.c net/ipv6/af_inet6.c +1 more+4 -40 repliesApplied
3/15ip: Fix data-races around sysctl_ip_fwd_use_pmtu.include/net/ip.h net/ipv4/route.c+2 -20 repliesApplied
4/15ip: Fix data-races around sysctl_ip_fwd_update_priority.drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c net/ipv4/ip_forward.c+3 -20 repliesApplied
5/15ip: Fix data-races around sysctl_ip_nonlocal_bind.include/net/inet_sock.h net/sctp/protocol.c+2 -20 repliesApplied
6/15ip: Fix a data-race around sysctl_ip_autobind_reuse.net/ipv4/inet_connection_sock.c+1 -10 repliesApplied
7/15ip: Fix a data-race around sysctl_fwmark_reflect.include/net/ip.h+1 -10 repliesApplied
8/15tcp/dccp: Fix a data-race around sysctl_tcp_fwmark_accept.include/net/inet_sock.h+2 -10 repliesApplied
9/15tcp: Fix data-races around sysctl_tcp_l3mdev_accept.include/net/inet_hashtables.h include/net/inet_sock.h+3 -30 repliesApplied
10/15tcp: Fix data-races around sysctl_tcp_mtu_probing.net/ipv4/tcp_output.c net/ipv4/tcp_timer.c+2 -20 repliesApplied
11/15tcp: Fix data-races around sysctl_tcp_base_mss.net/ipv4/tcp_output.c net/ipv4/tcp_timer.c+2 -20 repliesApplied
12/15tcp: Fix data-races around sysctl_tcp_min_snd_mss.net/ipv4/tcp_output.c net/ipv4/tcp_timer.c+3 -20 repliesApplied
13/15tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor.net/ipv4/tcp_timer.c+1 -10 repliesApplied
14/15tcp: Fix a data-race around sysctl_tcp_probe_threshold.net/ipv4/tcp_output.c+1 -10 repliesApplied
15/15tcp: Fix a data-race around sysctl_tcp_probe_interval.net/ipv4/tcp_output.c+1 -10 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 2).

This series fixes data-races around 15 knobs after ip_default_ttl in ipv4_net_table.

These two knobs are skipped.
- ip_local_port_range is safe with its own lock.
- ip_local_reserved_ports uses proc_do_large_bitmap(), which will need an additional lock and can be fixed later.

So, the next round will start with igmp_link_local_mcast_reports.

Kuniyuki Iwashima (15):
ip: Fix data-races around sysctl_ip_default_ttl.
ip: Fix data-races around sysctl_ip_no_pmtu_disc.
ip: Fix data-races around sysctl_ip_fwd_use_pmtu.
ip: Fix data-races around sysctl_ip_fwd_update_priority.
ip: Fix data-races around sysctl_ip_nonlocal_bind.
ip: Fix a data-race around sysctl_ip_autobind_reuse.
ip: Fix a data-race around sysctl_fwmark_reflect. tcp/dccp: Fix a data-race around sysctl_tcp_fwmark_accept.
tcp: Fix data-races around sysctl_tcp_l3mdev_accept.
tcp: Fix data-races around sysctl_tcp_mtu_probing.
tcp: Fix data-races around sysctl_tcp_base_mss.
tcp: Fix data-races around sysctl_tcp_min_snd_mss.
tcp: Fix a data-race around sysctl_tcp_mtu_probe_floor.
tcp: Fix a data-race around sysctl_tcp_probe_threshold.
tcp: Fix a data-race around sysctl_tcp_probe_interval.

 drivers/net/ethernet/mellanox/mlxsw/spectrum_router.c |  3 ++-
 drivers/net/ethernet/netronome/nfp/flower/action.c    |  2 +-
 include/net/inet_hashtables.h                         |  2 +-
 include/net/inet_sock.h                               |  9 +++++----
 include/net/ip.h                                      |  4 ++--
 include/net/route.h                                   |  2 +-
 net/ipv4/af_inet.c                                    |  2 +-
 net/ipv4/icmp.c                                       |  2 +-
 net/ipv4/inet_connection_sock.c                       |  2 +-
 net/ipv4/ip_forward.c                                 |  2 +-
 net/ipv4/ip_sockglue.c                                |  2 +-
 net/ipv4/netfilter/nf_reject_ipv4.c                   |  4 ++--
 net/ipv4/proc.c                                       |  2 +-
 net/ipv4/route.c                                      |  2 +-
 net/ipv4/tcp_output.c                                 | 11 ++++++-----
 net/ipv4/tcp_timer.c                                  |  8 ++++----
 net/ipv6/af_inet6.c                                   |  2 +-
 net/netfilter/nf_synproxy_core.c                      |  2 +-
 net/sctp/protocol.c                                   |  2 +-
 net/xfrm/xfrm_state.c                                 |  2 +-
 20 files changed, 35 insertions(+), 32 deletions(-)
Signature · 1 line
2.30.2