block/parallels: Fix buffer-based write call
Status from this message: Thanks, applied to my block branch.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | block/parallels: Fix buffer-based write callblock/ | +2 | 2 replies | |
| 2/2 | iotests/131: Add parallels regression testtests/ tests/ | +47 | 2 replies |
Reviews trailers per patch
All 2 patches have a Reviewed-by or Acked-by.
| Patch | Denis V. Lunev | Vladimir Sementsov-Ogievskiy |
|---|---|---|
| 1/2 | R-b | R-b |
| 2/2 | R-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] block/parallels: Fix buffer-based write call
Hi,
While reviewing Stefan’s libblkio driver series, I’ve noticed that block/parallels.c contains a call to bdrv_co_pwritev() that doesn’t pass a QEMUIOVector object but a plain buffer instead. That seems wrong and also pretty dangerous, so change it to a bdrv_co_pwrite() call (as I assume it should be), and add a regression test demonstrating the problem.
Hanna Reitz (2):
block/parallels: Fix buffer-based write call
iotests/131: Add parallels regression test
block/parallels.c | 4 ++-- tests/qemu-iotests/131 | 35 ++++++++++++++++++++++++++++++++++- tests/qemu-iotests/131.out | 13 +++++++++++++ 3 files changed, 49 insertions(+), 3 deletions(-)
Signature · 1 line
2.35.3