Skip to content

block/parallels: Fix buffer-based write call

Hanna Reitz qemu-devel 1 version Applied

Status from this message: Thanks, applied to my block branch.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2block/parallels: Fix buffer-based write callblock/parallels.c+2 -22 replies
2/2iotests/131: Add parallels regression testtests/qemu-iotests/131 tests/qemu-iotests/131.out+47 -12 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchDenis V. LunevVladimir Sementsov-Ogievskiy
1/2R-b R-b
2/2R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] block/parallels: Fix buffer-based write call

Hi,

While reviewing Stefan’s libblkio driver series, I’ve noticed that block/parallels.c contains a call to bdrv_co_pwritev() that doesn’t pass a QEMUIOVector object but a plain buffer instead. That seems wrong and also pretty dangerous, so change it to a bdrv_co_pwrite() call (as I assume it should be), and add a regression test demonstrating the problem.

Hanna Reitz (2):
block/parallels: Fix buffer-based write call
iotests/131: Add parallels regression test

 block/parallels.c          |  4 ++--
 tests/qemu-iotests/131     | 35 ++++++++++++++++++++++++++++++++++-
 tests/qemu-iotests/131.out | 13 +++++++++++++
 3 files changed, 49 insertions(+), 3 deletions(-)
Signature · 1 line
2.35.3