Skip to content

Misc NPCM7XX patches

Hao Wu qemu-arm qemu-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 of 8 patches 0 repliesNew

5 of 8 patches are in this archive. The cover letter announces 8.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hw/i2c: Clear ACK bit in NPCM7xx SMBus modulehw/i2c/npcm7xx_smbus.c+1 -10 replies
2/8hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBushw/i2c/npcm7xx_smbus.c+3 -30 replies
3/8hw/adc: Fix CONV bit in NPCM7XX ADC CON registerhw/adc/npcm7xx_adc.c tests/qtest/npcm7xx_adc-test.c+2 -20 replies
4/8hw/adc: Make adci[*] R/W in NPCM7XX ADChw/adc/npcm7xx_adc.c+1 -10 replies
5/8blockdev: Add a new IF type IF_OTHERblockdev.c include/sysemu/blockdev.h+4 -10 replies

Reviews trailers per patch

4 of 5 patches have a Reviewed-by or Acked-by.

PatchTitus RwantarePeter MaydellCorey MinyardPatrick Venture
1/8R-b R-b
2/8R-b A-b
3/8R-b R-b
4/8R-b R-b
5/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH 0/8] Misc NPCM7XX patches

[NOTE: I'm reviving a bunch of patches that was in the process of upstreaming a while ago but paused.]

This patch set contains a few bug fixes and I2C devices for some NPCM7XX boards.

Patch 1~2 fix a problem that causes the SMBus module to behave incorrectly when it's in FIFO mode and trying to receive more than 16 bytes at a time.

Patch 3 fixes a error in a register for ADC module.

Patch 4 makes the ADC input to be R/W instead of write only. It allows a test system to read these via QMP and has no negative effect.

Patch 5 adds a new blockdev IF type IF_OTHER.

Patch 6 allows at24c_eeprom_init to take a bus as parameter so it can be used by more use cases (e.g. behind an I2C mux.)

Patch 7 allows at24c_eeprom_init to take a drive as property, similar to sdhci_attach_device().

Patch 8 uses the function defined in patch 5 to add the EEPROM and other I2C devices for Quanta GBS board.

-- Changes since v4:
1. Add comments to patch 5.
2. Split patch 6 into 2 patches according to the feedback. Each patch does it own task.

-- Changes since v3:
1. Add a new blockdev IF type IF_OTHER.
2. Use IF_OTHER instead of IF_NONE.

-- Changes since v2:
1. Dropped patch 7.
2. Drop an extra variable in patch 5.

-- Changes since v1:
1. Rewrote patch 5 to implement the function in NPCM7xx board file instead of the EEPROM device file.
2. Slightly modify patch 6 to adapt to the changes and QEMU comment style.
3. Squash patch 7 into patch 5 to make it compile.
4. Add a new patch 7.

Hao Wu (7):
hw/i2c: Clear ACK bit in NPCM7xx SMBus module hw/i2c: Read FIFO during RXF_CTL change in NPCM7XX SMBus hw/adc: Fix CONV bit in NPCM7XX ADC CON register hw/adc: Make adci[*] R/W in NPCM7XX ADC
blockdev: Add a new IF type IF_OTHER
hw/arm: npcm8xx_boards: EEPROMs can take bus as parameter hw/arm: Set drive property for at24c eeprom

Patrick Venture (1):
hw/arm: quanta-gbs-bmc add i2c devices

 blockdev.c                     |   4 +-
 hw/adc/npcm7xx_adc.c           |   4 +-
 hw/arm/npcm7xx_boards.c        | 102 ++++++++++++++++++++-------------
 hw/i2c/npcm7xx_smbus.c         |   8 +--
 include/sysemu/blockdev.h      |   1 +
 tests/qtest/npcm7xx_adc-test.c |   2 +-
 6 files changed, 73 insertions(+), 48 deletions(-)
Signature · 1 line
2.37.0.170.g444d1eabd0-goog