Skip to content

nfsd: close potential race between open and delegation

Jeff Layton linux-nfs 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 2 repliesIn review
  2. v12 patches 6 repliesSuperseded

Changes in v2 from the cover letter

- use nfsd_lookup_dentry instead of lookup_one_len

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nfsd: drop fh argument from alloc_init_delegfs/nfsd/nfs4state.c+6 -80 replies
2/2nfsd: vet the opened dentry after setting a delegationfs/nfsd/nfs4state.c+47 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 0/2] nfsd: close potential race between open and delegation

v2:
- use nfsd_lookup_dentry instead of lookup_one_len

Here's a respin of the patches to fix up the potential race between an open and delegation. I took Neil's advice an changed over to use nfsd_lookup_dentry.

This patchset is based on top of Neil's recent patchset entitled:

[PATCH 0/8] NFSD: clean up locking.

Tested with xfstests and it seemed to behave. I haven't done any testing to ensure that the race is actually fixed, mainly because I don't have a way to reliably reproduce it.

Jeff Layton (2):
nfsd: drop fh argument from alloc_init_deleg
nfsd: vet the opened dentry after setting a delegation

 fs/nfsd/nfs4state.c | 58 ++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 49 insertions(+), 9 deletions(-)
Signature · 1 line
2.36.1