Skip to content

xen-blk{back,front}: Fix two bugs in 'feature_persistent'

SeongJae Park linux-block lkml stable xen-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest3 patches 4 repliesIn review
  2. v32 patches 2 repliesSuperseded
  3. v21 patch 3 repliesSuperseded

Changes in v4 from the cover letter

(https://lore.kernel.org/xen-devel/[email protected]/)
- Split 'blkback' patch for each of the two issues
- Add 'Reported-by: Andrii Chepurnyi <[email protected]>'

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3xen-blkback: fix persistent grants negotiationdrivers/block/xen-blkback/xenbus.c+7 -80 replies
2/3xen-blkback: Apply 'feature_persistent' parameter when connectDocumentation/ABI/testing/sysfs-driver-xen-blkback drivers/block/xen-blkback/xenbus.c+4 -70 replies
3/3xen-blkfront: Apply 'feature_persistent' parameter when connectDocumentation/ABI/testing/sysfs-driver-xen-blkfront drivers/block/xen-blkfront.c+2 -40 replies

Reviews trailers per patch

None of the 3 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMaximilian HeyneJuergen Gross
SeriesR-b R-b
1/3
2/3
3/3

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/3] xen-blk{back,front}: Fix two bugs in 'feature_persistent'

Introduction of 'feature_persistent' made two bugs. First one is wrong overwrite of 'vbd->feature_gnt_persistent' in 'blkback' due to wrong parameter value caching position, and the second one is unintended behavioral change that could break previous dynamic frontend/backend persistent feature support changes. This patchset fixes the issues.

Changes from v3
(https://lore.kernel.org/xen-devel/[email protected]/)
- Split 'blkback' patch for each of the two issues
- Add 'Reported-by: Andrii Chepurnyi <[email protected]>'

Changes from v2
(https://lore.kernel.org/xen-devel/[email protected]/)
- Keep the behavioral change of v1
- Update blkfront's counterpart to follow the changed behavior
- Update documents for the changed behavior

Changes from v1
(https://lore.kernel.org/xen-devel/[email protected]/)
- Avoid the behavioral change
(https://lore.kernel.org/xen-devel/[email protected]/)
- Rebase on latest xen/tip/linux-next
- Re-work by SeongJae Park <[email protected]>
- Cc stable@

Maximilian Heyne (1):
xen-blkback: Apply 'feature_persistent' parameter when connect

SeongJae Park (2):
xen-blkback: fix persistent grants negotiation
xen-blkfront: Apply 'feature_persistent' parameter when connect

 .../ABI/testing/sysfs-driver-xen-blkback      |  2 +-
 .../ABI/testing/sysfs-driver-xen-blkfront     |  2 +-
 drivers/block/xen-blkback/xenbus.c            | 20 ++++++++-----------
 drivers/block/xen-blkfront.c                  |  4 +---
 4 files changed, 11 insertions(+), 17 deletions(-)
Signature · 1 line
2.25.1