Skip to content

net: dsa: qca8k: code split for qca8k

Christian Marangi lkml netdev 5 versions – Applied

Status from this message: This series was applied to netdev/net-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest14 patches 23 repliesApplied 14/14
  2. v414 patches 2 repliesSuperseded
  3. v314 patches 10 repliesSuperseded
Earlier versions · 2
VersionPostedPatchesRepliesStatus
v215 patches25 repliesSuperseded
v1 RFC4 patches24 repliesSuperseded

Changes in v5 from the cover letter

- Wrap function to single line/80 char
- Cache match data even for read_switch function
- Add additional review tag

Patches in v5 All 14 applied

#Subject and filesSizeRepliesApplied
1/14net: dsa: qca8k: cache match data to speed up accessdrivers/net/dsa/qca/qca8k.c drivers/net/dsa/qca/qca8k.h+12 -245 repliesApplied
2/14net: dsa: qca8k: make mib autocast feature optionaldrivers/net/dsa/qca/qca8k.c drivers/net/dsa/qca/qca8k.h+14 -22 repliesApplied
3/14net: dsa: qca8k: move mib struct to common codedrivers/net/dsa/qca/Makefile drivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c +1 more+67 -511 replyApplied
4/14net: dsa: qca8k: move qca8k read/write/rmw and reg table to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+44 -421 replyApplied
5/14net: dsa: qca8k: move qca8k bulk read/write helper to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+49 -371 replyApplied
6/14net: dsa: qca8k: move mib init function to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+39 -372 repliesApplied
7/14net: dsa: qca8k: move port set status/eee/ethtool stats function to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+113 -1051 replyApplied
8/14net: dsa: qca8k: move bridge functions to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+102 -931 replyApplied
9/14net: dsa: qca8k: move set age/MTU/port enable/disable functions to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+97 -882 repliesApplied
10/14net: dsa: qca8k: move port FDB/MDB function to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+317 -3112 repliesApplied
11/14net: dsa: qca8k: move port mirror functions to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+98 -931 replyApplied
12/14net: dsa: qca8k: move port VLAN functions to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+187 -1841 replyApplied
13/14net: dsa: qca8k: move port LAG functions to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+171 -1681 replyApplied
14/14net: dsa: qca8k: move read_switch_id function to common codedrivers/net/dsa/qca/qca8k-8xxx.c drivers/net/dsa/qca/qca8k-common.c drivers/net/dsa/qca/qca8k.h+30 -291 replyApplied

Reviews trailers per patch

All 14 patches have a Reviewed-by or Acked-by.

PatchVladimir OlteanFlorian Fainelli
1/14R-b R-b
2/14R-b R-b
3/14R-b R-b
4/14R-b R-b
5/14R-b R-b
6/14R-b R-b
7/14R-b R-b
8/14R-b R-b
9/14R-b R-b
10/14R-b R-b
11/14R-b R-b
12/14R-b R-b
13/14R-b R-b
14/14R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v5 thread

Cover letter [net-next PATCH v5 00/14] net: dsa: qca8k: code split for qca8k

This is needed ad ipq4019 SoC have an internal switch that is based on qca8k with very minor changes. The general function is equal.

Because of this we split the driver to common and specific code.

As the common function needs to be moved to a different file to be reused, we had to convert every remaining user of qca8k_read/write/rmw to regmap variant.
We had also to generilized the special handling for the ethtool_stats function that makes use of the autocast mib. (ipq4019 will have a different tagger and use mmio so it could be quicker to use mmio instead of automib feature)
And we had to convert the regmap read/write to bulk implementation to drop the special function that makes use of it. This will be compatible with ipq4019 and at the same time permits normal switch to use the eth mgmt way to send the entire ATU table read/write in one go.

v5:
- Wrap function to single line/80 char
- Cache match data even for read_switch function
- Add additional review tag
v4:
- Fix compilation error with clang compiler reported by kernel test bot
v3:
- Squash more patch to skip even more "migration patch"
- Add new patch to cache match data in priv struct
- Fix extra space
- Drop unnecessary cast to qca8k_priv from void pointers v2:
- Rework patch to drop dependency with bulk regmap (will be converted later)
- Split the split patch to additional patch
- Rework autocast_mib function and move it to match data

Christian Marangi (14):
net: dsa: qca8k: cache match data to speed up access
net: dsa: qca8k: make mib autocast feature optional
net: dsa: qca8k: move mib struct to common code
net: dsa: qca8k: move qca8k read/write/rmw and reg table to common
code
net: dsa: qca8k: move qca8k bulk read/write helper to common code
net: dsa: qca8k: move mib init function to common code
net: dsa: qca8k: move port set status/eee/ethtool stats function to
common code
net: dsa: qca8k: move bridge functions to common code
net: dsa: qca8k: move set age/MTU/port enable/disable functions to
common code
net: dsa: qca8k: move port FDB/MDB function to common code
net: dsa: qca8k: move port mirror functions to common code
net: dsa: qca8k: move port VLAN functions to common code
net: dsa: qca8k: move port LAG functions to common code
net: dsa: qca8k: move read_switch_id function to common code

 drivers/net/dsa/qca/Makefile                  |    1 +
 drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} | 1711 +++--------------
 drivers/net/dsa/qca/qca8k-common.c            | 1210 ++++++++++++
 drivers/net/dsa/qca/qca8k.h                   |  100 +
 4 files changed, 1549 insertions(+), 1473 deletions(-)
 rename drivers/net/dsa/qca/{qca8k.c => qca8k-8xxx.c} (63%)
 create mode 100644 drivers/net/dsa/qca/qca8k-common.c
Signature · 1 line
2.36.1