drm bridge updates
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest12 patches 22 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | drm/bridge: ps8640: Use atomic variants of drm_bridge_funcsdrivers/ | +12 | 1 reply | |
| 2/12 | drm/bridge: Drop unused drm_bridge_chain functionsdrivers/ include/ | +0 | 0 replies | |
| 3/12 | drm/mediatek: Drop chain_mode_fixup call in mode_valid()drivers/ | +0 | 2 replies | |
| 4/12 | drm/bridge: Drop drm_bridge_chain_mode_fixupdrivers/ include/ | +0 | 1 reply | |
| 5/12 | drm/bridge: sii8620: Use drm_bridge_funcs.atomic_checkdrivers/ | +11 | 2 replies | |
| 6/12 | drm/bridge: cros-ec-anx7688: Use drm_bridge_funcs.atomic_checkdrivers/ | +18 | 2 replies | |
| 7/12 | drm/bridge: tc358767: Use drm_bridge_funcs.atomic_checkdrivers/ | +6 | 3 replies | |
| 8/12 | drm/mediatek: Drop mtk_hdmi_bridge_mode_fixupdrivers/ | +0 | 3 replies | |
| 9/12 | drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_checkdrivers/ | +7 | 2 replies | |
| 10/12 | drm/omapdrm: Use drm_bridge_funcs.atomic_checkdrivers/ drivers/ drivers/ | +56 | 1 reply | |
| 11/12 | drm/bridge: Drop drm_bridge_funcs.mode_fixupdrivers/ include/ | +17 | 2 replies | |
| 12/12 | drm/todo: Add bridge related todo itemsDocumentation/ | +20 | 3 replies |
Reviews trailers per patch
All 12 patches have a Reviewed-by or Acked-by.
| Patch | Maxime Ripard | Laurent Pinchart | Dave Stevenson | Chun-Kuang Hu |
|---|---|---|---|---|
| 1/12 | R-b | R-b | ||
| 2/12 | R-b | R-b | ||
| 3/12 | R-b | R-b | A-b | |
| 4/12 | R-b | R-b | ||
| 5/12 | R-b | R-b | ||
| 6/12 | R-b | R-b | ||
| 7/12 | R-b | R-b | ||
| 8/12 | R-b | R-b | A-b | |
| 9/12 | R-b | R-b | ||
| 10/12 | R-b | |||
| 11/12 | R-b | R-b | ||
| 12/12 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.
Cover letter [PATCH v1 0/12] drm bridge updates
This is a collection of bridge patches that I had left unfinished more than a year ago. Now where I have some spare time I dusted them off for review and testing.
The patches builds, but has seen no run-time testing.
The patches are grouped like this:
1+2:
- Updates parade-ps8640 for atomic operation thus allowing the use of the atomic variants of drm_bridge_chain_pre_enable/ post_disable.
There is thus no users left of the non-atomic variants of drm_bridge_chain* so drop them all.
If other drivers needs this functionality they are supposed to use the atomic API.
This is a DSI to eDP converter, and I did not see a need for format negotiation - but I may be wrong?
3+4:
- Drop chain_mode_fixup in mediatek, and as there are no more users, drop the implementation of drm_bridge_chain_mode_fixup. The crucial part to review is the updated documentation for drm_bridge_funcs.atomic_check().
5-11:
- Convert all bridge drivers from mode_fixup to atomic_check. To do so add the necessary hooks to have an atomic state. I think the drivers will work using the atomic API, but it has seen no testing!
I did not see any need for format negotiation, but if needed let me know so we can fix it.
The last patch removes the mode_fixup support in drm_bridge.
12:
- Add a few todo items, in the hope others will jump in and convert some of the bridge drivers to the atomic API.
The patch groups are more or less independent, and I may land them out of order if one group is reviewed before the rest.
A few of the patches has already seen a review, but they need a bit more exposure as last review was more than a year ago.
Sam
Sam Ravnborg (12):
drm/bridge: ps8640: Use atomic variants of drm_bridge_funcs drm/bridge: Drop unused drm_bridge_chain functions drm/mediatek: Drop chain_mode_fixup call in mode_valid() drm/bridge: Drop drm_bridge_chain_mode_fixup drm/bridge: sii8620: Use drm_bridge_funcs.atomic_check drm/bridge: cros-ec-anx7688: Use drm_bridge_funcs.atomic_check drm/bridge: tc358767: Use drm_bridge_funcs.atomic_check drm/mediatek: Drop mtk_hdmi_bridge_mode_fixup drm/rcar-du: lvds: Use drm_bridge_funcs.atomic_check drm/omapdrm: Use drm_bridge_funcs.atomic_check drm/bridge: Drop drm_bridge_funcs.mode_fixup drm/todo: Add bridge related todo items
Documentation/gpu/todo.rst | 20 ++++ drivers/gpu/drm/bridge/cros-ec-anx7688.c | 28 ++++-- drivers/gpu/drm/bridge/parade-ps8640.c | 18 ++-- drivers/gpu/drm/bridge/sil-sii8620.c | 17 ++-- drivers/gpu/drm/bridge/tc358767.c | 21 ++--- drivers/gpu/drm/drm_bridge.c | 154 +------------------------------ drivers/gpu/drm/mediatek/mtk_hdmi.c | 19 ---- drivers/gpu/drm/omapdrm/dss/dpi.c | 31 ++++--- drivers/gpu/drm/omapdrm/dss/sdi.c | 31 ++++--- drivers/gpu/drm/omapdrm/dss/venc.c | 28 ++++-- drivers/gpu/drm/rcar-du/rcar_lvds.c | 12 ++- include/drm/drm_bridge.h | 91 ++++-------------- 12 files changed, 147 insertions(+), 323 deletions(-)