Skip to content

lib: utils/serial: Collection of UART code improvements

Andrew Jones opensbi 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4lib: utils/fdt: Factor out common uart node codelib/utils/fdt/fdt_helper.c+39 -922 replies
2/4lib: utils/serial: Initialize platform_uart_data to zerolib/utils/serial/fdt_serial_gaisler.c lib/utils/serial/fdt_serial_shakti.c lib/utils/serial/fdt_serial_sifive.c +3 more+6 -63 replies
2/4lib: utils/serial: Initialize platform_uart_data to zero+0 -01 reply
2/4lib: utils/serial: Initialize platform_uart_data to zero+0 -00 replies
3/4lib: serial: Clean up coding style in sifive-uart.clib/utils/serial/sifive-uart.c+8 -33 replies
4/4lib: utils/serial: Ensure baudrate is non-zero before usinglib/utils/serial/gaisler-uart.c lib/utils/serial/shakti-uart.c lib/utils/serial/sifive-uart.c +1 more+13 -63 replies
4/4lib: utils/serial: Ensure baudrate is non-zero before using+0 -01 reply
4/4lib: utils/serial: Ensure baudrate is non-zero before using+0 -00 replies

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchXiang WAnup Patel
1/4R-b
2/4R-b
2/4R-b
2/4R-b
3/4R-b R-b
4/4R-b
4/4R-b
4/4R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] lib: utils/serial: Collection of UART code improvements

This series is a collection of changes I made while reviewing the UART code. I've compile tested it and boot it on QEMU (which of course only tests uart8250). I did also pass in a DTB with 0 for 'current-speed' in the UART node and nothing interesting happened, so I guess that's good.

Andrew Jones (4):
lib: utils/fdt: Factor out common uart node code
lib: utils/serial: Initialize platform_uart_data to zero
lib: serial: Clean up coding style in sifive-uart.c
lib: utils/serial: Ensure baudrate is non-zero before using

 lib/utils/fdt/fdt_helper.c                  | 131 ++++++--------------
 lib/utils/serial/fdt_serial_gaisler.c       |   2 +-
 lib/utils/serial/fdt_serial_shakti.c        |   2 +-
 lib/utils/serial/fdt_serial_sifive.c        |   2 +-
 lib/utils/serial/fdt_serial_uart8250.c      |   2 +-
 lib/utils/serial/fdt_serial_xlnx_uartlite.c |   2 +-
 lib/utils/serial/gaisler-uart.c             |   2 +-
 lib/utils/serial/shakti-uart.c              |   8 +-
 lib/utils/serial/sifive-uart.c              |  13 +-
 lib/utils/serial/uart8250.c                 |   7 +-
 platform/fpga/openpiton/platform.c          |   2 +-
 11 files changed, 66 insertions(+), 107 deletions(-)
Signature · 1 line
2.36.1