Add basic test for nvme uring passthrough commands
Status from this message: Applied, thanks!
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v3 Latest5 patches 4 repliesApplied
- v25 patches 4 repliesSuperseded
- v15 patches 5 repliesSuperseded
Changes in v3 from the cover letter
- Skip test if argument is not nvme device and remove prints, as suggested by Jens.
- change nvme helper function name, as pointed by Jens.
- Remove wrong comment about command size, as per Kanchan's review
Patches in v3 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | configure: check for nvme uring command supportconfigure | +20 | 0 replies | |
| 2/5 | io_uring.h: sync sqe entry with 5.20 io_uringsrc/ | +15 | 0 replies | |
| 3/5 | nvme: add nvme opcodes, structures and helper functionstest/ | +168 | 0 replies | |
| 4/5 | test: add io_uring passthrough testtest/ test/ | +315 | 0 replies | |
| 5/5 | test/io_uring_passthrough: add test case for poll IOtest/ | +76 | 0 replies |
Reviews trailers per patch
None of the 5 patches has a Reviewed-by or Acked-by.
| Patch | Kanchan Joshi |
|---|---|
| 1/5 | |
| 2/5 | |
| 3/5 | |
| 4/5 | T-b |
| 5/5 | T-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH liburing v3 0/5] Add basic test for nvme uring passthrough commands
This patchset adds a way to test NVMe uring passthrough commands with nvme-ns character device. The uring passthrough was introduced with 5.19 io_uring.
To send nvme uring passthrough commands we require helpers to fetch NVMe char device (/dev/ngXnY) specific fields such as namespace id, lba size etc.
How to run:
./test/io_uring_passthrough.t /dev/ng0n1
It requires argument to be NVMe device, if not the test will be skipped.
The test covers write/read with verify for sqthread poll, vectored / nonvectored and fixed IO buffers, which can be extended in future. As of now iopoll is not supported for passthrough commands, there is a test for such case.
Changes from v2 to v3
- Skip test if argument is not nvme device and remove prints, as suggested by Jens.
- change nvme helper function name, as pointed by Jens.
- Remove wrong comment about command size, as per Kanchan's review
Ankit Kumar (5):
configure: check for nvme uring command support io_uring.h: sync sqe entry with 5.20 io_uring
nvme: add nvme opcodes, structures and helper functions
test: add io_uring passthrough test test/io_uring_passthrough: add test case for poll IO
configure | 20 ++ src/include/liburing/io_uring.h | 17 +- test/Makefile | 1 + test/io_uring_passthrough.c | 390 ++++++++++++++++++++++++++++++++ test/nvme.h | 168 ++++++++++++++ 5 files changed, 594 insertions(+), 2 deletions(-) create mode 100644 test/io_uring_passthrough.c create mode 100644 test/nvme.h
Signature · 1 line
2.17.1