Skip to content

sysctl: Fix data-races around ipv4_net_table (Round 5).

Kuniyuki Iwashima netdev 1 version Applied

Status from this message: This series was applied to netdev/net.git (master)

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest15 patches 1 replyApplied 15/15

Patches in v1 All 15 applied

#Subject and filesSizeRepliesApplied
1/15tcp: Fix data-races around sysctl_tcp_dsack.net/ipv4/tcp_input.c+2 -20 repliesApplied
2/15tcp: Fix a data-race around sysctl_tcp_app_win.net/ipv4/tcp_input.c+1 -10 repliesApplied
3/15tcp: Fix a data-race around sysctl_tcp_adv_win_scale.include/net/tcp.h+1 -10 repliesApplied
4/15tcp: Fix a data-race around sysctl_tcp_frto.net/ipv4/tcp_input.c+1 -10 repliesApplied
5/15tcp: Fix a data-race around sysctl_tcp_nometrics_save.net/ipv4/tcp_metrics.c+1 -10 repliesApplied
6/15tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.net/ipv4/tcp_metrics.c+4 -40 repliesApplied
7/15tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.net/ipv4/tcp_input.c net/mptcp/protocol.c+2 -20 repliesApplied
8/15tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.net/ipv4/tcp_output.c net/mptcp/options.c+3 -30 repliesApplied
9/15tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.net/ipv4/tcp_output.c+1 -10 repliesApplied
10/15tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.net/ipv4/tcp_input.c+1 -10 repliesApplied
11/15tcp: Fix a data-race around sysctl_tcp_min_tso_segs.net/ipv4/tcp_output.c+1 -10 repliesApplied
12/15tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.net/ipv4/tcp_output.c+1 -10 repliesApplied
13/15tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.net/ipv4/tcp_input.c+1 -10 repliesApplied
14/15tcp: Fix a data-race around sysctl_tcp_autocorking.net/ipv4/tcp.c+1 -10 repliesApplied
15/15tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.net/ipv4/tcp_input.c+2 -10 repliesApplied

Reviews trailers per patch

None of the 15 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchEric Dumazet
SeriesR-b
1/15
2/15
3/15
4/15
5/15
6/15
7/15
8/15
9/15
10/15
11/15
12/15
13/15
14/15
15/15

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH v1 net 00/15] sysctl: Fix data-races around ipv4_net_table (Round 5).

This series fixes data-races around 15 knobs after tcp_dsack in ipv4_net_table.

tcp_tso_win_divisor was skipped because it already uses READ_ONCE().

So, the final round for ipv4_net_table will start with tcp_pacing_ss_ratio.

Kuniyuki Iwashima (15):
tcp: Fix data-races around sysctl_tcp_dsack.
tcp: Fix a data-race around sysctl_tcp_app_win.
tcp: Fix a data-race around sysctl_tcp_adv_win_scale.
tcp: Fix a data-race around sysctl_tcp_frto.
tcp: Fix a data-race around sysctl_tcp_nometrics_save.
tcp: Fix data-races around sysctl_tcp_no_ssthresh_metrics_save.
tcp: Fix data-races around sysctl_tcp_moderate_rcvbuf.
tcp: Fix data-races around sysctl_tcp_workaround_signed_windows.
tcp: Fix a data-race around sysctl_tcp_limit_output_bytes.
tcp: Fix a data-race around sysctl_tcp_challenge_ack_limit.
tcp: Fix a data-race around sysctl_tcp_min_tso_segs.
tcp: Fix a data-race around sysctl_tcp_tso_rtt_log.
tcp: Fix a data-race around sysctl_tcp_min_rtt_wlen.
tcp: Fix a data-race around sysctl_tcp_autocorking.
tcp: Fix a data-race around sysctl_tcp_invalid_ratelimit.

 include/net/tcp.h      |  2 +-
 net/ipv4/tcp.c         |  2 +-
 net/ipv4/tcp_input.c   | 17 +++++++++--------
 net/ipv4/tcp_metrics.c | 10 +++++-----
 net/ipv4/tcp_output.c  | 10 +++++-----
 net/mptcp/options.c    |  2 +-
 net/mptcp/protocol.c   |  2 +-
 7 files changed, 23 insertions(+), 22 deletions(-)
Signature · 1 line
2.30.2