devlink: implement dry run support for flash update
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 27 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | devlink: add dry run attribute to flash updateDocumentation/ include/ include/ +1 more | +51 | 23 replies | |
| 2/2 | ice: support dry run of a flash update to validate firmware fileDocumentation/ drivers/ drivers/ +2 more | +39 | 3 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [net-next PATCH 0/2] devlink: implement dry run support for flash update
This is a re-send of the dry run support I submitted nearly a year ago at
https://lore.kernel.org/netdev/CO1PR11MB50898047B9C0FAA520505AFDD6B59@CO1PR11MB5089.namprd11.prod.outlook.com/
I had delayed sending this because of conflicting work in the ice driver at the time, but then forgot about it and never got around to resubmitting it.
This adds a DEVLINK_ATTR_DRY_RUN which is used to indicate a request to validate a potentially destructive operation without performing the actions yet. In theory it could be used for other devlink operations in the future.
For flash update, it allows the user to validate a flash image, including ensuring the driver for the device is willing to program it, without actually committing an update yet.
There is an accompanying series for iproute2 which allows adding the dry-run attribute. It does as Jakub suggested and checks the maximum attribute before allowing the dry run in order to avoid accidentally performing a real update on older kernels.
Jacob Keller (2):
devlink: add dry run attribute to flash update
ice: support dry run of a flash update to validate firmware file
Documentation/driver-api/pldmfw/index.rst | 10 ++++++++ .../networking/devlink/devlink-flash.rst | 23 +++++++++++++++++++ drivers/net/ethernet/intel/ice/ice_devlink.c | 3 ++- .../net/ethernet/intel/ice/ice_fw_update.c | 14 +++++++---- include/linux/pldmfw.h | 5 ++++ include/net/devlink.h | 2 ++ include/uapi/linux/devlink.h | 8 +++++++ lib/pldmfw/pldmfw.c | 12 ++++++++++ net/core/devlink.c | 19 ++++++++++++++- 9 files changed, 90 insertions(+), 6 deletions(-)
base-commit: 6e693a104207fbf5a22795c987e8964c0a1ffe2d
Signature · 1 line
2.35.1.456.ga9c7032d4631