Skip to content

Clean-up stale/unused hci_request.c code

Brian Gix linux-bluetooth 7 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v7 Latest9 patches 1 replyIn review 8 of 9 applied
  2. v610 patches 1 replySuperseded
  3. v510 patches 1 replySuperseded
Earlier versions · 4
VersionPostedPatchesRepliesStatus
v44 patches14 repliesSuperseded
v34 patches1 replySuperseded
v23 patches1 replyApplied 3/3
v13 patches1 replySuperseded

Patches in v7 8 of 9 applied

#Subject and filesSizeRepliesApplied
1/9Bluetooth: Convert le_scan_disable timeout to hci_syncnet/bluetooth/hci_request.c net/bluetooth/hci_sync.c+74 -971 replyApplied
2/9Bluetooth: Rework le_scan_restart for hci_syncnet/bluetooth/hci_request.c net/bluetooth/hci_sync.c+75 -890 repliesApplied
3/9Bluetooth: Delete unused hci_req_stop_discovery()net/bluetooth/hci_request.c net/bluetooth/hci_request.h+0 -500 repliesApplied
4/9Bluetooth: Convert SCO configure_datapath to hci_syncnet/bluetooth/hci_conn.c net/bluetooth/hci_request.c net/bluetooth/hci_request.h+75 -600 repliesApplied
5/9Bluetooth: Move Adv Instance timer to hci_syncinclude/net/bluetooth/hci_sync.h net/bluetooth/hci_request.c net/bluetooth/hci_request.h +2 more+125 -1270 repliesApplied
6/9Bluetooth: Delete unreferenced hci_request codenet/bluetooth/hci_request.c net/bluetooth/hci_request.h+2 -7680 repliesApplied
7/9Bluetooth: move hci_get_random_address() to hci_syncinclude/net/bluetooth/hci_sync.h net/bluetooth/hci_request.c net/bluetooth/hci_request.h +1 more+170 -1720 repliesApplied
8/9Bluetooth: convert hci_update_adv_data to hci_syncinclude/net/bluetooth/hci_sync.h net/bluetooth/hci_core.c net/bluetooth/hci_event.c +3 more+23 -680 repliesApplied
9/9Bluetooth: Convert hci_abort_conn to hci_syncinclude/net/bluetooth/hci_sync.h net/bluetooth/hci_conn.c net/bluetooth/hci_request.c +3 more+135 -980 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v7 yet.

Read the v7 thread

Cover letter [PATCH v7 0/9] Clean-up stale/unused hci_request.c code

This will be a growing patch-set of conversions and dead-code removal towards the goal of retiring hci_request.c

The patch sets will be split amoung the work queues and delayed work queues as initialized in hci_request_setup(), with the ultimate goal of eliminating hci_request.c entirely.

v2: Published

v3: Continuing work. This does include one conversion (SCO configure_datapath) that has been tested with mgmt-tester and sco-tester, but has not been tested with a controller with an off-loadable codec.

v4: Clean-up checkpatch warnings.

v5: Remove remaining procedures from hci_request.c/h. Not that other entities (notably amp.c, hci_event.c and hci_core.c) are still using the hci_request mechanism, however, the mgmt-tester unit test only currently execute opcode 0x1408 - HCI_OP_READ_ENC_KEY_SIZE during normal testing.

v6: Fix CI reported errors, and recoded hci_abort_conn for optional sync queue usage to fix some L2CAP test cases.

v7: Delete and rebase to remove conflicting interleave scan clean-up. Will be done using work Luiz has been working on.

Brian Gix (9):
Bluetooth: Convert le_scan_disable timeout to hci_sync
Bluetooth: Rework le_scan_restart for hci_sync
Bluetooth: Delete unused hci_req_stop_discovery()
Bluetooth: Convert SCO configure_datapath to hci_sync
Bluetooth: Move Adv Instance timer to hci_sync
Bluetooth: Delete unreferenced hci_request code
Bluetooth: move hci_get_random_address() to hci_sync
Bluetooth: convert hci_update_adv_data to hci_sync
Bluetooth: Convert hci_abort_conn to hci_sync

 include/net/bluetooth/hci_sync.h |   10 +-
 net/bluetooth/hci_conn.c         |   92 +-
 net/bluetooth/hci_core.c         |    2 +-
 net/bluetooth/hci_event.c        |    2 +-
 net/bluetooth/hci_request.c      | 1650 +++---------------------------
 net/bluetooth/hci_request.h      |   53 -
 net/bluetooth/hci_sync.c         |  500 ++++++++-
 net/bluetooth/mgmt.c             |    7 +-
 8 files changed, 733 insertions(+), 1583 deletions(-)
Signature · 1 line
2.37.1