Skip to content

ublk_drv: make sure that correct flags(features) returned to userspace

Ming Lei linux-block 4 versions Applied

Status from this message: Applied, thanks!

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest2 patches 2 repliesApplied
  2. v32 patches 3 repliesSuperseded
  3. v22 patches 8 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v12 patches3 repliesSuperseded

Changes in v4 from the cover letter

- move UBLK_F_ALL out of uapi header, and change order of clearing dev_info.flags as suggested by Chrisotph

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/2ublk_drv: fix error handling of ublk_add_devdrivers/block/ublk_drv.c+48 -520 replies
2/2ublk_drv: make sure that correct flags(features) returned to userspacedrivers/block/ublk_drv.c include/uapi/linux/ublk_cmd.h+18 -61 reply

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchChristoph HellwigZiyangZhang
1/2
2/2R-b R-b R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH V4 0/2] ublk_drv: make sure that correct flags(features) returned to userspace

Hello Jens,

The 1st patch cleans ublk_add_dev a bit, meantime fix one potential free un-allocated buffer issue.

The 2nd one makes sure that driver supported flags returned to userspace, this way is important for maintaining compatibility.

V4:
- move UBLK_F_ALL out of uapi header, and change order of clearing dev_info.flags as suggested by Chrisotph

V3:
- cleanup ublk_ctrl_add_dev by Christoph

V2:
- avoid double free device in case that char dev is failed to add

Christoph Hellwig (1):
ublk_drv: fix error handling of ublk_add_dev

Ming Lei (1):
ublk_drv: make sure that correct flags(features) returned to userspace

 drivers/block/ublk_drv.c      | 115 ++++++++++++++++++----------------
 include/uapi/linux/ublk_cmd.h |   7 ++-
 2 files changed, 65 insertions(+), 57 deletions(-)
Signature · 1 line
2.31.1