Skip to content

nfs: fix -ENOSPC DIO write regression

Jeff Layton linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3nfs: add new nfs_direct_req tracepoint eventsfs/nfs/direct.c fs/nfs/internal.h fs/nfs/nfstrace.h+114 -330 replies
2/3nfs: always check dreq->error after a commitfs/nfs/direct.c+2 -10 replies
3/3nfs: only issue commit in DIO codepath if we have uncommitted datafs/nfs/direct.c fs/nfs/write.c include/linux/nfs_xdr.h+32 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] nfs: fix -ENOSPC DIO write regression

Boyang reported that xfstest generic/476 would never complete when run against a filesystem that was "too small".

What I found was that we would end up trying to issue a large DIO write that would come back short. The kernel would then follow up and try to write out the rest and get back -ENOSPC. It would then try to issue a commit, which would then try to reissue the writes, and around it would go.

This patchset seems to fix it. Unfortunately, I'm not positive which patch _broke_ this as it seems to have happened quite some time ago.

Jeff Layton (3):
nfs: add new nfs_direct_req tracepoint events
nfs: always check dreq->error after a commit
nfs: only issue commit in DIO codepath if we have uncommitted data

 fs/nfs/direct.c         | 50 +++++++++--------------------
 fs/nfs/internal.h       | 33 ++++++++++++++++++++
 fs/nfs/nfstrace.h       | 69 +++++++++++++++++++++++++++++++++++++++++
 fs/nfs/write.c          | 48 +++++++++++++++++-----------
 include/linux/nfs_xdr.h |  1 +
 5 files changed, 148 insertions(+), 53 deletions(-)
Signature · 1 line
2.36.1