Skip to content

genimage.cfg file clean-up

Thomas Petazzoni via buildroot buildroot 1 version Applied

Status from this message: Applied to master, Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 2 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/8board/orangepi/common/genimage.cfg: use quotes around "gpt"board/orangepi/common/genimage.cfg+1 -10 replies
2/8board/*/genimage.cfg: use partition-table-type = "gpt"board/octavo/osd32mp1-brk/genimage.cfg board/octavo/osd32mp1-red/genimage.cfg board/olimex/stmp1_olinuxino/genimage.cfg +2 more+5 -50 replies
3/8docs/manual: update documentation about partition-type-uuid convention in genimage.cfgdocs/manual/writing-rules.txt+12 -01 reply
4/8board/orangepi/orangepi-r1/genimage.cfg: remove double quotes around partition-type-uuid valuesboard/orangepi/orangepi-r1/genimage.cfg+2 -20 replies
5/8board/orangepi/orangepi-r1/genimage.cfg: use correct partition typeboard/orangepi/orangepi-r1/genimage.cfg+1 -10 replies
6/8board/*/genimage.cfg: use partition-type-uuid U where relevantboard/aarch64-efi/genimage-efi.cfg board/pc/genimage-efi.cfg board/qemu/aarch64-sbsa/genimage.cfg+3 -30 replies
7/8board/sifive/hifive-unleashed/genimage*: convert partition-type-uuid values to lower-caseboard/sifive/hifive-unleashed/genimage_sdcard.cfg board/sifive/hifive-unleashed/genimage_spi-nor.cfg+5 -50 replies
8/8board/*/genimage.cfg: use partition-type-uuid = F for some FAT partitionsboard/friendlyarm/nanopc-t4/genimage.cfg board/friendlyarm/nanopi-m4/genimage.cfg board/pine64/rockpro64/genimage.cfg +3 more+6 -60 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [Buildroot] [PATCH 0/8] genimage.cfg file clean-up

Hello,

This small series is a revamp of Giulio's series cleaning up genimage.cfg. This new version is the result of some discussion between Arnout and me to find a middle-ground situation.

So what we propose is to:

- Use the U and F specifiers provided by genimage for the EFI System Partition and FAT32 partitions respectively.

- Use the L specifier (explicitly specified in genimage.cfg, even though it is the default), for the root filesystem or other Linux filesystems. This means we would not comply with the systemd-specific Discoverable Partitions Specification
(https://systemd.io/DISCOVERABLE_PARTITIONS/), but we don't see the point of this specification (which requires identifying root filesystems for different architecture by different GUID) in the context of Buildroot. However, while we recommend using L for all new genimage.cfg, we do not change existing genimage.cfg, to not break them.

In this series, none of the patches except the last make any functional change. The last patch does introduce some functional
change: some partitions were identified as EFI System Partition even though they are not: the last commit converts them to use the "F" type, used for FAT filesystems.

Best regards,

Thomas Petazzoni

Thomas Petazzoni (8):
board/orangepi/common/genimage.cfg: use quotes around "gpt" board/*/genimage.cfg: use partition-table-type = "gpt" docs/manual: update documentation about partition-type-uuid convention
in genimage.cfg
board/orangepi/orangepi-r1/genimage.cfg: remove double quotes around
partition-type-uuid values
board/orangepi/orangepi-r1/genimage.cfg: use correct partition type board/*/genimage.cfg: use partition-type-uuid U where relevant board/sifive/hifive-unleashed/genimage*: convert partition-type-uuid
values to lower-case
board/*/genimage.cfg: use partition-type-uuid = F for some FAT
partitions

 board/aarch64-efi/genimage-efi.cfg                   |  2 +-
 board/friendlyarm/nanopc-t4/genimage.cfg             |  2 +-
 board/friendlyarm/nanopi-m4/genimage.cfg             |  2 +-
 board/octavo/osd32mp1-brk/genimage.cfg               |  2 +-
 board/octavo/osd32mp1-red/genimage.cfg               |  2 +-
 board/olimex/stmp1_olinuxino/genimage.cfg            |  2 +-
 board/orangepi/common/genimage.cfg                   |  2 +-
 board/orangepi/orangepi-r1/genimage.cfg              |  4 ++--
 board/pc/genimage-efi.cfg                            |  2 +-
 board/pine64/rockpro64/genimage.cfg                  |  2 +-
 board/qemu/aarch64-sbsa/genimage.cfg                 |  2 +-
 board/radxa/rockpi-4/genimage.cfg                    |  2 +-
 board/radxa/rockpi-n10/genimage.cfg                  |  2 +-
 board/radxa/rockpi-n8/genimage.cfg                   |  2 +-
 board/seeed/stm32mp157c-odyssey/genimage.cfg         |  2 +-
 board/sifive/hifive-unleashed/genimage_sdcard.cfg    |  6 +++---
 board/sifive/hifive-unleashed/genimage_spi-nor.cfg   |  4 ++--
 .../common/stm32mp157/genimage.cfg.template          |  2 +-
 docs/manual/writing-rules.txt                        | 12 ++++++++++++
 19 files changed, 34 insertions(+), 22 deletions(-)
Signature · 6 lines
2.37.1

_______________________________________________
buildroot mailing list
[email protected]
https://lists.buildroot.org/mailman/listinfo/buildroot