Skip to content

USB: cdc: add control and state defines

Johan Hovold linux-staging linux-usb lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7USB: cdc: add control-signal definesinclude/uapi/linux/usb/cdc.h+4 -01 reply
2/7USB: cdc: add serial-state definesinclude/uapi/linux/usb/cdc.h+9 -01 reply
3/7USB: cdc-acm: use CDC control-line definesdrivers/usb/class/cdc-acm.c drivers/usb/class/cdc-acm.h+9 -161 reply
4/7USB: cdc-acm: use CDC serial-state definesdrivers/usb/class/cdc-acm.c drivers/usb/class/cdc-acm.h+12 -251 reply
5/7staging: gdm724x: drop unused CDC definesdrivers/staging/gdm724x/gdm_tty.c+0 -60 replies
6/7USB: gadget: f_acm: use CDC definesdrivers/usb/gadget/function/f_acm.c+5 -150 replies
7/7USB: serial: usb_wwan: replace DTR/RTS magic numbers with macrosdrivers/usb/serial/usb_wwan.c+6 -40 replies

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchOliver Neukum
1/7A-b
2/7A-b
3/7A-b
4/7A-b
5/7
6/7
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] USB: cdc: add control and state defines

Several drivers use the control-line and serial-state bitmap values from the CDC spec, but there were no matching defines in the global CDC (UAPI) header.

This series adds the missing defines and converts cdc-acm and f_acm to use them.

One staging driver also had an unused set of CDC defines which are removed.

The final patch by Yan Xinyu, which triggered this work, converts the usb_wwan driver to use CDC defines instead of hardcoded values in its line-control handling.

Greg, are you ok with me taking these through USB serial (where there are a few more drivers that could potentially use them) or do you want to take the lot through your tree directly?

Johan

Johan Hovold (6):
USB: cdc: add control-signal defines
USB: cdc: add serial-state defines
USB: cdc-acm: use CDC control-line defines
USB: cdc-acm: use CDC serial-state defines
staging: gdm724x: drop unused CDC defines
USB: gadget: f_acm: use CDC defines

Yan Xinyu (1):
USB: serial: usb_wwan: replace DTR/RTS magic numbers with macros

 drivers/staging/gdm724x/gdm_tty.c   |  6 -----
 drivers/usb/class/cdc-acm.c         | 42 ++++++++++++++---------------
 drivers/usb/class/cdc-acm.h         | 20 --------------
 drivers/usb/gadget/function/f_acm.c | 20 ++++----------
 drivers/usb/serial/usb_wwan.c       | 10 ++++---
 include/uapi/linux/usb/cdc.h        | 13 +++++++++
 6 files changed, 45 insertions(+), 66 deletions(-)
Signature · 1 line
2.35.1