Skip to content

RFC KVM: selftests: Rename perf_test_util to memstress

David Matlack kvm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2KVM: selftests: Rename perf_test_util.[ch] to memstress.[ch]tools/testing/selftests/kvm/Makefile tools/testing/selftests/kvm/access_tracking_perf_test.c tools/testing/selftests/kvm/demand_paging_test.c +5 more+13 -130 replies
2/2KVM: selftests: Rename perf_test_util symbols to memstresstools/testing/selftests/kvm/access_tracking_perf_test.c tools/testing/selftests/kvm/demand_paging_test.c tools/testing/selftests/kvm/dirty_log_perf_test.c +4 more+114 -1140 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchAndrew Jones
SeriesA-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 0/2] KVM: selftests: Rename perf_test_util to memstress

This series renames the perf_test_util to memstress. patch 1 renames the files perf_test_util.[ch] to memstress.[ch], and patch 2 replaces the perf_test_ prefix on symbols with memstress_.

The reason for this rename, as with any rename, is to improve readability. perf_test_util is too generic and does not describe at all what the library does, other than being used for perf tests.

I considered a lot of different names (naming is hard) and eventually settled on memstress for a few reasons:

- "memstress" better describes the functionality proveded by this library, which is to run a VM that reads/writes to memory from all vCPUs in parallel (i.e. stressing VM memory).

- "memstress" contains the same number of characters as "perf_test", making it a drop in replacement in symbols wihout changing line lengths.

- The lack of underscore between "mem" and "stress" makes it clear "memstress" is a noun, avoiding confusion in function names.

Looking to the future, I think "memstress" will remain a good name. Specifically there are some in-flight improvements that will make this library even more of a "memory stress tester":

- A proposed series by yours truly [1] extends memstress/perf_test_util to support execute from memory, in addition to reading/writing.

- Colton Lewis within Google is looking into adding support for more complex memory access patterns.

[1] https://lore.kernel.org/kvm/[email protected]/

David Matlack (2):
KVM: selftests: Rename perf_test_util.[ch] to memstress.[ch]
KVM: selftests: Rename perf_test symbols to memstress

 tools/testing/selftests/kvm/Makefile          |  4 +-
 .../selftests/kvm/access_tracking_perf_test.c | 20 +++----
 .../selftests/kvm/demand_paging_test.c        | 20 +++----
 .../selftests/kvm/dirty_log_perf_test.c       | 22 ++++----
 .../include/{perf_test_util.h => memstress.h} | 34 ++++++------
 .../kvm/lib/{perf_test_util.c => memstress.c} | 54 +++++++++----------
 .../x86_64/{perf_test_util.c => memstress.c}  | 36 ++++++-------
 .../kvm/memslot_modification_stress_test.c    | 16 +++---
 8 files changed, 103 insertions(+), 103 deletions(-)
 rename tools/testing/selftests/kvm/include/{perf_test_util.h => memstress.h} (50%)
 rename tools/testing/selftests/kvm/lib/{perf_test_util.c => memstress.c} (83%)
 rename tools/testing/selftests/kvm/lib/x86_64/{perf_test_util.c => memstress.c} (68%)

base-commit: 1a4d88a361af4f2e91861d632c6a1fe87a9665c2
prerequisite-patch-id: 8c230105c8a2f1245dedb5b386327d98865d0bb2
prerequisite-patch-id: 9b4329037e2e880db19f3221e47d956b78acadc8

Signature · 1 line
2.37.1.359.gd136c6c3e2-goog