Skip to content

tpm_tis_i2c: Fix -Wdeclaration-after-statement

Peter Delevoryas openbmc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1tpm_tis_i2c: Fix -Wdeclaration-after-statementdrivers/char/tpm/tpm_tis_i2c.c+13 -230 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/1] tpm_tis_i2c: Fix -Wdeclaration-after-statement

Hey Joel,

I've been trying to build fby35 from https://github.com/openbmc/openbmc, and I noticed that the TPM TIS I2C file seems to emit a warning that causes a compilation error:

../drivers/char/tpm/tpm_tis_i2c.c: In function ‘tpm_tis_i2c_write_bytes’:
../drivers/char/tpm/tpm_tis_i2c.c:114:17: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]

  114 |                 struct i2c_msg msgs[] = {
      |                 ^~~~~~

I'm sending this patch as a fix for the warning, to avoid the compilation error.

Normally I think I would send this to the upstream kernel mailing list, but this file doesn't actually seem to be in the upstream at any point:

drivers/char/tpm/tpm_tis_i2c.c

It looks like it was added by Nuvoton and never upstreamed successfully? Perhaps we should get rid of it at this point? fby35 doesn't actually use the TPM TIS I2C interface, it uses the SPI one. Bletchley doesn't use the I2C one either. Only older FB platforms did.

Actually, doing a quick search on lore.kernel.org: It looks like maybe there's a new version submitted by Infineon in June:

    https://lore.kernel.org/all/[email protected]/

If fby35 wants to avoid this error, should we fix the driver, remove it from the kernel, pull in the new driver from upstream, or maybe just disable it in the linux-aspeed tpm2 distro feature Kconfig?

Thanks,
Peter

Peter Delevoryas (1):
tpm_tis_i2c: Fix -Wdeclaration-after-statement

 drivers/char/tpm/tpm_tis_i2c.c | 36 ++++++++++++----------------------
 1 file changed, 13 insertions(+), 23 deletions(-)
Signature · 1 line
2.37.1