xfs stable patches for 5.10.y (from v5.13+)
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v2 Latest9 patches 1 replyIn review
- v19 patches 5 repliesSuperseded
Changes in v2 from the cover letter
- Survived a week of crash recovery loop
- Added Acked-by Darrick
- CC stable
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[v1] https://lore.kernel.org/linux-xfs/[email protected]/
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | xfs: refactor xfs_file_fsyncfs/ | +50 | 0 replies | |
| 2/9 | xfs: xfs_log_force_lsn isn't passed a LSNfs/ fs/ fs/ +10 more | +56 | 0 replies | |
| 3/9 | xfs: prevent UAF in xfs_log_item_in_current_chkptfs/ | +3 | 0 replies | |
| 4/9 | xfs: fix log intent recovery ENOSPC shutdowns when inactivating inodesfs/ | +9 | 0 replies | |
| 5/9 | xfs: force the log offline when log intent item recovery failsfs/ fs/ | +7 | 0 replies | |
| 6/9 | xfs: hold buffer across unpin and potential shutdown processingfs/ | +21 | 0 replies | |
| 7/9 | xfs: remove dead stale buf unpin handling codefs/ | +2 | 0 replies | |
| 8/9 | xfs: logging the on disk inode LSN can make it go backwardsfs/ fs/ | +39 | 0 replies | |
| 9/9 | xfs: Enforce attr3 buffer recovery orderfs/ | +1 | 0 replies |
Reviews trailers per patch
All 9 patches have a Reviewed-by or Acked-by.
| Patch | Brian Foster | Darrick J. Wong | Dave Chinner | Allison Henderson | Christoph Hellwig |
|---|---|---|---|---|---|
| 1/9 | R-b | R-b A-b | R-b | ||
| 2/9 | R-b | R-b A-b | R-b | ||
| 3/9 | A-b | R-b | |||
| 4/9 | A-b | R-b | |||
| 5/9 | A-b | R-b | |||
| 6/9 | R-b A-b | ||||
| 7/9 | R-b A-b | ||||
| 8/9 | R-b A-b | ||||
| 9/9 | R-b A-b | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH 5.10 v2 0/9] xfs stable patches for 5.10.y (from v5.13+)
Hi Greg,
This backport series contains mostly fixes from v5.14 release along with one fix deferred from the first joint 5.10/5.15 series [1].
The upstream commit f8d92a66e810 ("xfs: prevent UAF in xfs_log_item_in_current_chkpt") was already applied to 5.15.y, but its 5.10.y backport was more involved (required two non trivial dependency patches), so it needed more time for review and testing.
Per Darrick's recommendation, on top of the usual regression tests, I also ran the "recoveryloop" tests group for an extended period of time to test for rare regressions.
Some recoveryloop tests were failing at rates less frequent than 1/100, but no change in failure rate was observed between baseline (v5.10.131) and the backport branch.
There was one exceptional test, xfs/455, that was reporting data corruptions after crash at very low rate - less frequent than 1/1000 on both baseline and backport branch.
It is hard to draw solid conclusions with such rare failures, but the test was run >10,000 times on baseline and >20,000 times on backport branch, so as far as our test coverage can attest, these backports are not introducing any obvious xfs regressions to 5.10.y.
Thanks,
Amir.
Changes from [v1]:
- Survived a week of crash recovery loop
- Added Acked-by Darrick
- CC stable
[1] https://lore.kernel.org/linux-xfs/[email protected]/
[v1] https://lore.kernel.org/linux-xfs/[email protected]/
Brian Foster (2):
xfs: hold buffer across unpin and potential shutdown processing
xfs: remove dead stale buf unpin handling code
Christoph Hellwig (1):
xfs: refactor xfs_file_fsync
Darrick J. Wong (3):
xfs: prevent UAF in xfs_log_item_in_current_chkpt
xfs: fix log intent recovery ENOSPC shutdowns when inactivating inodes
xfs: force the log offline when log intent item recovery fails
Dave Chinner (3):
xfs: xfs_log_force_lsn isn't passed a LSN
xfs: logging the on disk inode LSN can make it go backwards
xfs: Enforce attr3 buffer recovery order
fs/xfs/libxfs/xfs_log_format.h | 11 ++++- fs/xfs/libxfs/xfs_types.h | 1 + fs/xfs/xfs_buf_item.c | 60 ++++++++++-------------- fs/xfs/xfs_buf_item_recover.c | 1 + fs/xfs/xfs_dquot_item.c | 2 +- fs/xfs/xfs_file.c | 81 ++++++++++++++++++++------------- fs/xfs/xfs_inode.c | 10 ++-- fs/xfs/xfs_inode_item.c | 4 +- fs/xfs/xfs_inode_item.h | 2 +- fs/xfs/xfs_inode_item_recover.c | 39 ++++++++++++---- fs/xfs/xfs_log.c | 30 ++++++------ fs/xfs/xfs_log.h | 4 +- fs/xfs/xfs_log_cil.c | 32 +++++-------- fs/xfs/xfs_log_priv.h | 15 +++--- fs/xfs/xfs_log_recover.c | 5 +- fs/xfs/xfs_mount.c | 10 +++- fs/xfs/xfs_trans.c | 6 +-- fs/xfs/xfs_trans.h | 4 +- 18 files changed, 179 insertions(+), 138 deletions(-)
Signature · 1 line
2.25.1