Skip to content

dm verity: optionally use tasklets

Mike Snitzer dm-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v2 Latest6 patches 12 repliesIn review

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6dm bufio: Add flags argument to dm_bufio_client_createdrivers/md/dm-bufio.c drivers/md/dm-ebs-target.c drivers/md/dm-integrity.c +5 more+13 -90 replies
2/6dm bufio: Add DM_BUFIO_CLIENT_NO_SLEEP flagdrivers/md/dm-bufio.c include/linux/dm-bufio.h+24 -34 replies
3/6dm verity: Add optional "try_verify_in_tasklet" featuredrivers/md/dm-verity-target.c drivers/md/dm-verity.h+83 -140 replies
4/6dm verity: allow optional args to alter primary args handlingdrivers/md/dm-verity-target.c+24 -80 replies
5/6dm bufio: conditionally enable branching for DM_BUFIO_CLIENT_NO_SLEEPdrivers/md/dm-bufio.c+11 -40 replies
6/6dm verity: conditionally enable branching for "try_verify_in_tasklet"drivers/md/dm-verity-target.c+14 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [dm-devel] [PATCH v2 0/6] dm verity: optionally use tasklets

Hi,

Please see this updated patchset that reflects what I've staged for the 5.20 merge window, see:
https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/log/?h=dm-5.20

My only outstanding question, from previous v1 patchset, is: should the verify_wq be created using WQ_HIGHPRI instead of WQ_CPU_INTENSIVE? (I doubt it has a significant impact on performance but if you have insight on why you made that change, and if it meaningful, I'd happily apply the change).

I've tested using cryptsetup's testsuite (which has dm-verity tests) but I haven't tested the "try_verify_in_tasklet" feature.

I'd welcome review and focused "try_verify_in_tasklet" testing.

Thanks,
Mike

Mike Snitzer (3):
dm verity: allow optional args to alter primary args handling dm bufio: conditionally enable branching for DM_BUFIO_CLIENT_NO_SLEEP dm verity: conditionally enable branching for "try_verify_in_tasklet"

Nathan Huckleberry (3):
dm bufio: Add flags argument to dm_bufio_client_create dm bufio: Add DM_BUFIO_CLIENT_NO_SLEEP flag
dm verity: Add optional "try_verify_in_tasklet" feature

 drivers/md/dm-bufio.c                         |  32 ++++-
 drivers/md/dm-ebs-target.c                    |   3 +-
 drivers/md/dm-integrity.c                     |   2 +-
 drivers/md/dm-snap-persistent.c               |   2 +-
 drivers/md/dm-verity-fec.c                    |   4 +-
 drivers/md/dm-verity-target.c                 | 121 +++++++++++++++---
 drivers/md/dm-verity.h                        |   7 +-
 drivers/md/persistent-data/dm-block-manager.c |   3 +-
 include/linux/dm-bufio.h                      |   8 +-
 9 files changed, 154 insertions(+), 28 deletions(-)
Signature · 6 lines
2.32.1 (Apple Git-133)

--
dm-devel mailing list
[email protected]
https://listman.redhat.com/mailman/listinfo/dm-devel