Skip to content

nvme: honor DNR status for authentication

Hannes Reinecke linux-nvme 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest2 patches 5 repliesIn review
  2. v11 patch 2 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2nvme-auth: retry command if DNR bit is not setdrivers/nvme/host/auth.c drivers/nvme/host/core.c include/linux/blk-mq.h+21 -33 replies
2/2nvme-auth: set the DNR bit if authentication faileddrivers/nvme/host/auth.c drivers/nvme/host/fabrics.c+12 -122 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchSagi Grimberg
1/2
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCHv2 0/2] nvme: honor DNR status for authentication

Hi all,

when sending authentication commands we should be checking the DNR bit in the cqe status to figure out if a command should be retried. So the first patch will evaluate the DNR bit during _nvme_submit_sync_cmd() and initiate a retry, and the second patch will set the DNR bit in the nvme authentication code such that we don't attempt to retry the 'connect' operation.
I have opened pull request #100 for blktests to validate this behaviour.

As usual, comments and reviews are welcome.

Hannes Reinecke (2):
nvme-auth: retry command if DNR bit is not set
nvme-auth: set the DNR bit if authentication failed

 drivers/nvme/host/auth.c    | 22 +++++++++++-----------
 drivers/nvme/host/core.c    | 20 ++++++++++++++++++--
 drivers/nvme/host/fabrics.c |  4 ++--
 include/linux/blk-mq.h      |  2 ++
 4 files changed, 33 insertions(+), 15 deletions(-)
Signature · 1 line
2.35.3