KVM: arm64: nVHE stack unwinder rework
Status from this message: Applied to next, thanks!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | KVM: arm64: Move PROTECTED_NVHE_STACKTRACE aroundarch/ | +11 | 0 replies | |
| 2/6 | KVM: arm64: Move nVHE stacktrace unwinding into its own compilation unitarch/ arch/ arch/ +1 more | +123 | 0 replies | |
| 3/6 | KVM: arm64: Make unwind()/on_accessible_stack() per-unwinder functionsarch/ arch/ arch/ +3 more | +213 | 1 reply | |
| 4/6 | KVM: arm64: Move nVHE-only helpers into kvm/stacktrace.carch/ arch/ | +41 | 0 replies | |
| 5/6 | KVM: arm64: Don't open code ARRAY_SIZE()arch/ arch/ | +5 | 0 replies | |
| 6/6 | arm64: Update 'unwinder howto'arch/ | +4 | 0 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | Kalesh Singh | Oliver Upton | Mark Brown |
|---|---|---|---|
| Series | R-b T-b | R-b | |
| 1/6 | |||
| 2/6 | |||
| 3/6 | R-b | ||
| 4/6 | |||
| 5/6 | |||
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.
Cover letter [PATCH 0/6] KVM: arm64: nVHE stack unwinder rework
Hi all,
As Kalesh's series[1] already went through quite a few rounds and that it has proved to be an extremely useful debugging help, I'd like to queue it for 5.20.
However, there is a couple of nits that I'd like to address:
- the code is extremely hard to follow, due to the include maze and the various levels of inline functions that have forward declarations...
- there is a subtle bug in the way the kernel on_accessible_stack() helper has been rewritten
- the config symbol for the protected unwinder is oddly placed
Instead of going for another round and missing the merge window, I propose to stash the following patches on top, which IMHO result in something much more readable.
This series directly applies on top of Kalesh's.
[1] https://lore.kernel.org/r/[email protected]
Marc Zyngier (5):
KVM: arm64: Move PROTECTED_NVHE_STACKTRACE around
KVM: arm64: Move nVHE stacktrace unwinding into its own compilation
unit
KVM: arm64: Make unwind()/on_accessible_stack() per-unwinder functions
KVM: arm64: Move nVHE-only helpers into kvm/stacktrace.c
arm64: Update 'unwinder howto'
Oliver Upton (1):
KVM: arm64: Don't open code ARRAY_SIZE()
arch/arm64/include/asm/stacktrace.h | 74 ------- arch/arm64/include/asm/stacktrace/common.h | 69 ++----- arch/arm64/include/asm/stacktrace/nvhe.h | 125 +----------- arch/arm64/kernel/stacktrace.c | 90 +++++++++ arch/arm64/kvm/Kconfig | 24 ++- arch/arm64/kvm/Makefile | 2 +- arch/arm64/kvm/handle_exit.c | 98 --------- arch/arm64/kvm/hyp/nvhe/stacktrace.c | 55 +++++- arch/arm64/kvm/stacktrace.c | 218 +++++++++++++++++++++ 9 files changed, 394 insertions(+), 361 deletions(-) create mode 100644 arch/arm64/kvm/stacktrace.c
Signature · 1 line
2.34.1