Skip to content

Bug fix for recent batching change

Logan Gunthorpe linux-raid lkml 1 version Applied

Status from this message: Applied to md-next. Thanks!

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 9 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/5md/raid5: Refactor raid5_get_active_stripe()drivers/md/raid5.c+36 -316 replies
2/5md/raid5: Make is_inactive_blocked() helperdrivers/md/raid5.c+19 -51 reply
3/5md/raid5: Drop unnecessary call to r5c_check_stripe_cache_usage()drivers/md/raid5.c+0 -10 replies
4/5md/raid5: Move stripe_request_ctx updrivers/md/raid5.c+27 -270 replies
5/5md/raid5: Ensure batch_last is released before sleeping for quiescedrivers/md/raid5.c drivers/md/raid5.h+29 -91 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] Bug fix for recent batching change

Hey,

We hit another bug on my recent batching patch. In this case the bug has never been hit with the current md/md-next branch but some other patches we were working on changed the timing such that we hit this bug. It is theoretically possible to hit in the md/md-next batch so this patchset contains a fix.

The fix is the last commit. The first four commits are some basic refactoring that makes the final commit a bit easier.

A git repo is here and is based on current md/md-next (7a6f9e9cf1):

https://github.com/sbates130272/linux-p2pmem raid5_batch_quiesce

Thanks,

Logan

--

Logan Gunthorpe (5):
md/raid5: Refactor raid5_get_active_stripe()
md/raid5: Make is_inactive_blocked() helper
md/raid5: Drop unnecessary call to r5c_check_stripe_cache_usage() md/raid5: Move stripe_request_ctx up
md/raid5: Ensure batch_last is released before sleeping for quiesce

 drivers/md/raid5.c | 162 ++++++++++++++++++++++++++++-----------------
 drivers/md/raid5.h |   2 +-
 2 files changed, 101 insertions(+), 63 deletions(-)

base-commit: 7a6f9e9cf1befa0a1578501966d3c9b0cae46727 --
2.30.2