Skip to content

Fixes and improvements to GuC logging and error capture

[email protected] dri-devel intel-gfx 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 22 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7drm/i915/guc: Add a helper for log buffer sizedrivers/gpu/drm/i915/gt/uc/intel_guc_log.c+27 -222 replies
2/7drm/i915/guc: Fix capture size warning and bump the sizedrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c drivers/gpu/drm/i915/gt/uc/intel_guc_capture.h drivers/gpu/drm/i915/gt/uc/intel_guc_log.c +1 more+31 -181 reply
3/7drm/i915/guc: Add GuC <-> kernel time stamp translation informationdrivers/gpu/drm/i915/gt/intel_gt_regs.h drivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc.h +3 more+40 -06 replies
4/7drm/i915/guc: Record CTB info in error logsdrivers/gpu/drm/i915/i915_gpu_error.c drivers/gpu/drm/i915/i915_gpu_error.h+67 -122 replies
5/7drm/i915/guc: Use streaming loads to speed up dumping the guc logdrivers/gpu/drm/i915/gt/uc/intel_guc_log.c+18 -62 replies
6/7drm/i915/guc: Make GuC log sizes runtime configurabledrivers/gpu/drm/i915/gt/uc/intel_guc.c drivers/gpu/drm/i915/gt/uc/intel_guc_capture.c drivers/gpu/drm/i915/gt/uc/intel_guc_log.c +3 more+226 -747 replies
7/7drm/i915/guc: Reduce spam from error capturedrivers/gpu/drm/i915/gt/uc/intel_guc_capture.c+28 -391 reply

Reviews trailers per patch

All 7 patches have a Reviewed-by or Acked-by.

PatchMatthew BrostJohn HarrisonAlan Previn
1/7R-b R-b
2/7R-b
3/7R-b
4/7R-b
5/7R-b R-b
6/7R-b
7/7R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [PATCH 0/7] Fixes and improvements to GuC logging and error capture

From: John Harrison <[email protected]>

Fix bugs and improve the usability/effectiveness of GuC logging and GuC related error captures.

Alan Previn (1):
drm/i915/guc: Add a helper for log buffer size

Chris Wilson (1):
drm/i915/guc: Use streaming loads to speed up dumping the guc log

John Harrison (5):
drm/i915/guc: Fix capture size warning and bump the size drm/i915/guc: Add GuC <-> kernel time stamp translation information drm/i915/guc: Record CTB info in error logs drm/i915/guc: Make GuC log sizes runtime configurable drm/i915/guc: Reduce spam from error capture

 drivers/gpu/drm/i915/gt/intel_gt_regs.h       |   2 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.c        |  72 +++--
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   2 +
 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 113 ++++----
 .../gpu/drm/i915/gt/uc/intel_guc_capture.h    |   1 -
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.c    | 253 +++++++++++++++---
 drivers/gpu/drm/i915/gt/uc/intel_guc_log.h    |  42 +--
 drivers/gpu/drm/i915/i915_gpu_error.c         |  67 ++++-
 drivers/gpu/drm/i915/i915_gpu_error.h         |  21 +-
 drivers/gpu/drm/i915/i915_params.c            |  12 +
 drivers/gpu/drm/i915/i915_params.h            |   3 +
 11 files changed, 427 insertions(+), 161 deletions(-)
Signature · 1 line
2.37.1