Skip to content

sched, cgroup/cpuset: Keep user set cpus affinity

Waiman Long cgroups lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 9 repliesIn review
  2. v43 patches 4 repliesSuperseded
  3. v33 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v22 patches4 repliesSuperseded

Changes in v5 from the cover letter

- Update patch 3 to handle race with concurrent sched_setaffinity() by rechecking a previously cleared user_cpus_ptr afterward.

Patches in v5 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sched: Use user_cpus_ptr for saving user provided cpumask in sched_setaffinity()kernel/sched/core.c kernel/sched/sched.h+52 -495 replies
2/3sched: Provide copy_user_cpus_mask() to copy out user maskinclude/linux/sched.h kernel/sched/core.c+20 -00 replies
3/3cgroup/cpuset: Keep user set cpus affinitykernel/cgroup/cpuset.c+40 -24 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH v5 0/3] sched, cgroup/cpuset: Keep user set cpus affinity

v5:
- Update patch 3 to handle race with concurrent sched_setaffinity() by rechecking a previously cleared user_cpus_ptr afterward.

v4:
- Update patch 1 to make sched_setaffinity() the only function to update user_cpus_ptr to make the logic simpler and easier to understand. restrict_cpus_allowed_ptr() and relax_compatible_cpus_allowed_ptr() will just use it if present.

v3:
- Attach a new patch 2 to introduce a copy_user_cpus_mask() to copy out user masks with lock protection & use it in patch 3.

v2:
- Rework the v1 patch by extending the semantics of user_cpus_ptr to store user set cpus affinity and keeping to it as much as possible.

The user_cpus_ptr field is added by commit b90ca8badbd1 ("sched:
Introduce task_struct::user_cpus_ptr to track requested affinity") which uses it narrowly to allow keeping cpus affinity intact with asymmetric cpu setup.

This patchset extends user_cpus_ptr to store user set cpus affinity via sched_setaffinity() API. With that information available, it will enable cpuset to keep cpus afinity as close to what the user wants as possible within the cpu list constraint of the current cpuset. Otherwise some change to the cpuset hierarchy may reset the cpumask of the tasks in the affected cpusets to the default cpuset value even if those tasks have cpus affinity explicitly set by the users before.

It also means that once sched_setaffinity() is called, user_cpus_ptr will remain allocated until the task exits.

Waiman Long (3):
sched: Use user_cpus_ptr for saving user provided cpumask in
sched_setaffinity()
sched: Provide copy_user_cpus_mask() to copy out user mask cgroup/cpuset: Keep user set cpus affinity

 include/linux/sched.h  |   1 +
 kernel/cgroup/cpuset.c |  42 ++++++++++++++-
 kernel/sched/core.c    | 119 ++++++++++++++++++++++++-----------------
 kernel/sched/sched.h   |   1 -
 4 files changed, 112 insertions(+), 51 deletions(-)
Signature · 1 line
2.31.1