Skip to content

destructive bpf_kfuncs

Artem Savkov bpf lkml netdev 4 versions – Applied

Status from this message: This series was applied to bpf/bpf-next.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v5 Latest3 patches 0 repliesApplied 3/3
  2. v43 patches 2 repliesSuperseded
  3. v33 patches 5 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v23 patches4 repliesSuperseded

Changes in v5 from the cover letter

- documentation numbering fixed
- no more warning on failed kfunc registration

Patches in v5 All 3 applied

#Subject and filesSizeRepliesApplied
1/3bpf: add destructive kfunc flagDocumentation/bpf/kfuncs.rst include/linux/btf.h kernel/bpf/verifier.c+16 -10 repliesApplied
2/3bpf: export crash_kexec() as destructive kfunckernel/bpf/helpers.c+18 -00 repliesApplied
3/3selftests/bpf: add destructive kfunc testnet/bpf/test_run.c tools/testing/selftests/bpf/prog_tests/kfunc_call.c tools/testing/selftests/bpf/progs/kfunc_call_destructive.c+55 -00 repliesApplied

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v5 yet.

Read the v5 thread

Cover letter [PATCH bpf-next v5 0/3] destructive bpf_kfuncs

eBPF is often used for kernel debugging, and one of the widely used and powerful debugging techniques is post-mortem debugging with a full memory dump. Triggering a panic at exactly the right moment allows the user to get such a dump and thus a better view at the system's state. Right now the only way to do this in BPF is to signal userspace to trigger kexec/panic. This is suboptimal as going through userspace requires context changes and adds significant delays taking system further away from "the right moment". On a single-cpu system the situation is even worse because BPF program won't even be able to block the thread of interest.

This patchset tries to solve this problem by allowing properly marked tracing bpf programs to call crash_kexec() kernel function. The only requirement for now to run programs calling crash_kexec() or other destructive kfuncs is CAP_SYS_BOOT capability. When signature checking for bpf programs is available it is possible that stricter rules will be applied to programs utilizing destructive kfuncs.

Changes in v5:
- documentation numbering fixed
- no more warning on failed kfunc registration

Changes in v4:
- added description for KF_DESTRUCTIVE flag to documentation

Changes in v3:
- moved kfunc set registration to kernel/bpf/helpers.c

Changes in v2:
- BPF_PROG_LOAD flag dropped as it doesn't fully achieve it's aim of preventing accidental execution of destructive bpf programs
- selftest moved to the end of patchset
- switched to kfunc destructive flag instead of a separate set

Changes from RFC:
- sysctl knob dropped
- using crash_kexec() instead of panic()
- using kfuncs instead of adding a new helper

Artem Savkov (3):
bpf: add destructive kfunc flag
bpf: export crash_kexec() as destructive kfunc
selftests/bpf: add destructive kfunc test

 Documentation/bpf/kfuncs.rst                  |  9 +++++
 include/linux/btf.h                           |  3 +-
 kernel/bpf/helpers.c                          | 18 ++++++++++
 kernel/bpf/verifier.c                         |  5 +++
 net/bpf/test_run.c                            |  5 +++
 .../selftests/bpf/prog_tests/kfunc_call.c     | 36 +++++++++++++++++++
 .../bpf/progs/kfunc_call_destructive.c        | 14 ++++++++
 7 files changed, 89 insertions(+), 1 deletion(-)
 create mode 100644 tools/testing/selftests/bpf/progs/kfunc_call_destructive.c
Signature · 1 line
2.37.1