Skip to content

virtio: remove unnecessary host_features in ->get_features()

Stefan Hajnoczi qemu-devel 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest posting 2/22 patches 3 repliesIn review
  2. v3 posting 1/23 patches 0 repliesSuperseded
  3. v22 patches 2 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v11 patch1 replySuperseded

Changes in v3 from the cover letter

- On top of master instead of the qemu.git/staging tree :) v3:
- Use an informal comment instead of a full doc comment [Cornelia] v2:
- Document vdv->get_features() callback [Cornelia]

Patches in v3 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio: document ->host_features usage in vdc->get_features() callbackinclude/hw/virtio/virtio.h+7 -01 reply
2/2virtio: remove unnecessary host_features in ->get_features()hw/block/virtio-blk.c hw/char/virtio-serial-bus.c hw/net/virtio-net.c +3 more+0 -162 replies

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchCornelia Huck
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH RESEND v3 0/2] virtio: remove unnecessary host_features in ->get_features()

v3 (resend):
- On top of master instead of the qemu.git/staging tree :) v3:
- Use an informal comment instead of a full doc comment [Cornelia] v2:
- Document vdv->get_features() callback [Cornelia]

The vdc->get_features() callbacks are a little inconsistent in how they use vdev->host_features. This is because the function's behavior changed over time. Clean things up.

Stefan Hajnoczi (2):
virtio: document ->host_features usage in vdc->get_features() callback
virtio: remove unnecessary host_features in ->get_features()

 include/hw/virtio/virtio.h  | 7 +++++++
 hw/block/virtio-blk.c       | 3 ---
 hw/char/virtio-serial-bus.c | 1 -
 hw/net/virtio-net.c         | 3 ---
 hw/scsi/vhost-scsi-common.c | 3 ---
 hw/scsi/virtio-scsi.c       | 4 ----
 hw/virtio/virtio-balloon.c  | 2 --
 7 files changed, 7 insertions(+), 16 deletions(-)
Signature · 1 line
2.38.1