Skip to content

occ: Restore default behavior of polling OCC during init

Eddie James linux-devicetree linux-hwmon lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest3 patches 3 repliesIn review
  2. v13 patches 5 repliesSuperseded

Changes in v2 from the cover letter

- Fix bindings and rename ibm,inactive-on-init to ibm,no-poll-on-init
- Fix incorrect MODULE_DEVICE_TABLE argument

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3dt-bindings: hwmon: Add IBM OCC bindingsDocumentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml+39 -01 reply
2/3fsi: occ: Support probing the hwmon child device from dts nodedrivers/fsi/fsi-occ.c+34 -70 replies
3/3hwmon: (occ) Check for device property for setting OCC active during probedrivers/hwmon/occ/common.c drivers/hwmon/occ/p9_sbe.c+19 -12 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchGuenter Roeck
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v2 thread

Cover letter [PATCH v2 0/3] occ: Restore default behavior of polling OCC during init

A recent change to the OCC hwmon driver modified the default behavior to no longer poll the OCC during initialization. This does change the interface, meaning that old applications will not work with the more recent driver. To resolve this issue, introduce a new dts property to control the behavior of the driver during initialization, similar to the FSI master property "no-scan-on-init". Without the new "ibm,no-poll-on-init" boolean present, the driver will now do the previous behavior of polling the OCC.

Changes since v1:
- Fix bindings and rename ibm,inactive-on-init to ibm,no-poll-on-init
- Fix incorrect MODULE_DEVICE_TABLE argument

Eddie James (3):
dt-bindings: hwmon: Add IBM OCC bindings
fsi: occ: Support probing the hwmon child device from dts node
hwmon: (occ) Check for device property for setting OCC active during
probe

 .../bindings/hwmon/ibm,occ-hwmon.yaml         | 39 ++++++++++++++++++
 drivers/fsi/fsi-occ.c                         | 41 +++++++++++++++----
 drivers/hwmon/occ/common.c                    | 11 ++++-
 drivers/hwmon/occ/p9_sbe.c                    |  9 ++++
 4 files changed, 92 insertions(+), 8 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/hwmon/ibm,occ-hwmon.yaml
Signature · 1 line
2.31.1

Read the cover letter in its thread