Skip to content

asus-wmi: add support for ROG XFlow tablet mode

Luke D. Jones lkml platform-driver-x86 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest2 patches 4 repliesIn review
  2. v22 patches 9 repliesSuperseded
  3. v11 patch 2 repliesSuperseded

Changelog from the cover letter

- V3:
+ Use dev_err() in place of pr_err() in asus_wmi_input_init()
+ Adjust declaration of variables vs instantiation to match expected pattern
- V2:
+ Refactor the base handling paths of tablet modes to use enum
+ Add support for ROG XFlow using the refactored code

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2asus-wmi: Adjust tablet/lidflip handling to use enumdrivers/platform/x86/asus-nb-wmi.c drivers/platform/x86/asus-wmi.c drivers/platform/x86/asus-wmi.h+58 -311 reply
2/2asus-wmi: Add support for ROG X13 tablet modedrivers/platform/x86/asus-nb-wmi.c drivers/platform/x86/asus-wmi.c drivers/platform/x86/asus-wmi.h +1 more+54 -03 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 0/2] asus-wmi: add support for ROG XFlow tablet mode

This patch series refactors a part of the tablet/lid-flip code to use an enum to set the different behaviours, and adds support for the ASUS ROG XFlow (X13) 2-in-1 laptop.

Changelog:
- V3:
+ Use dev_err() in place of pr_err() in asus_wmi_input_init()
+ Adjust declaration of variables vs instantiation to match expected pattern
- V2:
+ Refactor the base handling paths of tablet modes to use enum
+ Add support for ROG XFlow using the refactored code

This obsoletes a previous patch I submitted:
- https://lkml.org/lkml/2022/8/3/94

Luke D. Jones (2):
asus-wmi: Adjust tablet/lidflip handling to use enum
asus-wmi: Add support for ROG X13 tablet mode

 drivers/platform/x86/asus-nb-wmi.c         |  28 ++++--
 drivers/platform/x86/asus-wmi.c            | 104 ++++++++++++++++-----
 drivers/platform/x86/asus-wmi.h            |  10 +-
 include/linux/platform_data/x86/asus-wmi.h |   1 +
 4 files changed, 112 insertions(+), 31 deletions(-)
Signature · 1 line
2.37.1