Skip to content

enable pnv-phb user created devices

Daniel Henrique Barboza qemu-devel 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 16 repliesIn review
  2. v311 patches 8 repliesSuperseded
  3. v110 patches 9 repliesSuperseded

Changes in v4 from the cover letter

- patch 4:
- added Error **errp parameter to pnv_parent_bus_fixup() and pnv_phb_user_device_init()
- added pnv_chip_add_phb() helper
- patch 5:
- changed pnv_chip_power8_instance_init() to use an 'Object *phb' pointer
- patch 6:
- added the default PHBs under an "if (defaults_enabled())" case
- patch 7:
- pnv_phb4_get_pec() was moved to hw/ppc/pnv.c
- patch 9:
- use g_assert_not_reached() in pnv_phb4_get_pec()
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01548.html

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ppc/pnv: add phb-id/chip-id PnvPHB3RootBus propertieshw/pci-host/pnv_phb3.c include/hw/pci-host/pnv_phb3.h+58 -11 reply
2/11ppc/pnv: add phb-id/chip-id PnvPHB4RootBus propertieshw/pci-host/pnv_phb4.c include/hw/pci-host/pnv_phb4.h+61 -01 reply
3/11ppc/pnv: set root port chassis and slot using Bus propertieshw/pci-host/pnv_phb.c+16 -91 reply
4/11ppc/pnv: add helpers for pnv-phb user deviceshw/pci-host/pnv_phb.c hw/ppc/pnv.c include/hw/ppc/pnv.h+96 -02 replies
5/11ppc/pnv: turn chip8->phbs[] into a PnvPHB* arrayhw/ppc/pnv.c include/hw/ppc/pnv.h+27 -62 replies
6/11ppc/pnv: enable user created pnv-phb for powernv8hw/pci-host/pnv_phb.c hw/ppc/pnv.c+25 -161 reply
7/11ppc/pnv: add PHB4 helpers for user created pnv-phbhw/ppc/pnv.c+32 -32 replies
8/11ppc/pnv: enable user created pnv-phb for powernv9hw/pci-host/pnv_phb.c hw/pci-host/pnv_phb4_pec.c hw/ppc/pnv.c+7 -31 reply
9/11ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecshw/ppc/pnv.c+15 -22 replies
10/11ppc/pnv: user creatable pnv-phb for powernv10hw/ppc/pnv.c+2 -01 reply
11/11ppc/pnv: fix QOM parenting of user creatable root portshw/pci-host/pnv_phb.c+15 -202 replies

Reviews trailers per patch

10 of 11 patches have a Reviewed-by or Acked-by.

PatchCédric Le GoaterFrederic Barrat
1/11R-b R-b
2/11R-b R-b
3/11R-b R-b
4/11R-b R-b
5/11R-b R-b
6/11R-b R-b
7/11R-b R-b
8/11R-b R-b
9/11R-b R-b
10/11R-b R-b
11/11

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH for-7.2 v4 00/11] enable pnv-phb user created devices

Hi,

This version contains changes based on Cedric's v3 feedback. The biggest change was made in patch 4, where a new helper was added to handle the logic where a PHB is added to a chip.

Changes from v3:
- patch 4:
- added Error **errp parameter to pnv_parent_bus_fixup() and pnv_phb_user_device_init()
- added pnv_chip_add_phb() helper
- patch 5:
- changed pnv_chip_power8_instance_init() to use an 'Object *phb' pointer
- patch 6:
- added the default PHBs under an "if (defaults_enabled())" case
- patch 7:
- pnv_phb4_get_pec() was moved to hw/ppc/pnv.c
- patch 9:
- use g_assert_not_reached() in pnv_phb4_get_pec()
- v3 link: https://lists.gnu.org/archive/html/qemu-devel/2022-08/msg01548.html

Daniel Henrique Barboza (11):
ppc/pnv: add phb-id/chip-id PnvPHB3RootBus properties ppc/pnv: add phb-id/chip-id PnvPHB4RootBus properties ppc/pnv: set root port chassis and slot using Bus properties ppc/pnv: add helpers for pnv-phb user devices ppc/pnv: turn chip8->phbs[] into a PnvPHB* array ppc/pnv: enable user created pnv-phb for powernv8 ppc/pnv: add PHB4 helpers for user created pnv-phb ppc/pnv: enable user created pnv-phb for powernv9 ppc/pnv: change pnv_phb4_get_pec() to also retrieve chip10->pecs ppc/pnv: user creatable pnv-phb for powernv10 ppc/pnv: fix QOM parenting of user creatable root ports

 hw/pci-host/pnv_phb.c          | 120 +++++++++++++++++++++++++++------
 hw/pci-host/pnv_phb3.c         |  50 ++++++++++++++
 hw/pci-host/pnv_phb4.c         |  51 ++++++++++++++
 hw/pci-host/pnv_phb4_pec.c     |   6 +-
 hw/ppc/pnv.c                   | 103 +++++++++++++++++++++++++---
 include/hw/pci-host/pnv_phb3.h |   9 ++-
 include/hw/pci-host/pnv_phb4.h |  10 +++
 include/hw/ppc/pnv.h           |   7 +-
 8 files changed, 325 insertions(+), 31 deletions(-)
Signature · 1 line
2.36.1