RFC workqueue: Fix for prematurely wakeups and cleanups
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest8 patches 7 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | workqueue: Unconditionally set cpumask in worker_attach_to_pool()kernel/ | +5 | 3 replies | |
| 2/8 | workqueue: Make create_worker() safe against prematurely wakeupskernel/ kernel/ | +23 | 4 replies | |
| 3/8 | workqueue: Set PF_NO_SETAFFINITY instead of kthread_bind_mask()kernel/ | +3 | 0 replies | |
| 4/8 | workqueue: Set/Clear PF_WQ_WORKER while attaching/detachingkernel/ | +12 | 0 replies | |
| 5/8 | workqueue: Use worker_set_flags() in worker_enter_idle()kernel/ | +1 | 0 replies | |
| 6/8 | workqueue: Simplify the starting of the newly created workerkernel/ | +17 | 0 replies | |
| 7/8 | workqueue: Remove the outer loop in maybe_create_worker()kernel/ | +0 | 3 replies | |
| 8/8 | workqueue: Move the locking out of maybe_create_worker()kernel/ | +3 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC PATCH 0/8] workqueue: Fix for prematurely wakeups and cleanups
From: Lai Jiangshan <[email protected]>
Patch1-3 are fixes for prematurely wakeups and patch4-8 are cleanups.
Patch2 fixes when prematurely wakeup happens after kthread_bind_mask(). Patch3 fixes when prematurely wakeup happens before kthread_bind_mask(). Patch1 prepares for patch2-3.
Like Petr's patch[1], a completion is introduced to do the synchronization, but the synchronization is done in a different direction which allows the newly created worker itself do some initialization instead of the manager and allows for a more simplified code.
(The changed synchronization direction is not necessarily better.)
And make workqueue code less dependence on the semantics that kthread provides.
[1]: https://lore.kernel.org/all/[email protected]/
Cc: Linus Torvalds <[email protected]>
Cc: "Eric W. Biederman" <[email protected]>
Cc: Tejun Heo <[email protected]>,
Cc: Petr Mladek <[email protected]>
Cc: Michal Hocko <[email protected]>,
Cc: Peter Zijlstra <[email protected]>,
Cc: Wedson Almeida Filho <[email protected]>
Lai Jiangshan (8):
workqueue: Unconditionally set cpumask in worker_attach_to_pool()
workqueue: Make create_worker() safe against prematurely wakeups
workqueue: Set PF_NO_SETAFFINITY instead of kthread_bind_mask()
workqueue: Set/Clear PF_WQ_WORKER while attaching/detaching
workqueue: Use worker_set_flags() in worker_enter_idle()
workqueue: Simplify the starting of the newly created worker
workqueue: Remove the outer loop in maybe_create_worker()
workqueue: Move the locking out of maybe_create_worker()
kernel/workqueue.c | 123 +++++++++++++++--------------------- kernel/workqueue_internal.h | 11 +++- 2 files changed, 60 insertions(+), 74 deletions(-)
Signature · 1 line
2.19.1.6.gb485710b