Skip to content

clk: gcc-sc8280xp: fix broken suspend

Johan Hovold linux-arm-msm linux-clk lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2clk: gcc-sc8280xp: keep PCIe power-domains always-ondrivers/clk/qcom/gcc-sc8280xp.c+9 -51 reply
2/2clk: gcc-sc8280xp: keep USB power-domains always-ondrivers/clk/qcom/gcc-sc8280xp.c+7 -01 reply

Reviews trailers per patch

All 2 patches have a Reviewed-by or Acked-by.

PatchManivannan Sadhasivam
1/2R-b
2/2R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] clk: gcc-sc8280xp: fix broken suspend

The Qualcomm PCIe driver currently does not implement suspend at all so we need to mark the GDSCs as always-on to prevent genpd from disabling them.

Similarly, the Qualcomm dwc3 USB suspend implementation is also incomplete and the controller doesn't currently survive a suspend cycle unless the GDSC is kept on. Note that this has nothing to with whether wakeup is enabled or not (cf. [1]).

With these two workarounds, we have somewhat functional suspend on the SC8280XP reference design and Lenovo Thinkpad X13s until the missing driver support is in place (even USB remote wakeup works with [2] applied).

Johan

[1] https://lore.kernel.org/all/[email protected]/
[2] https://lore.kernel.org/all/[email protected]/

Johan Hovold (2):
clk: gcc-sc8280xp: keep PCIe power-domains always-on
clk: gcc-sc8280xp: keep USB power-domains always-on

 drivers/clk/qcom/gcc-sc8280xp.c | 21 ++++++++++++++++-----
 1 file changed, 16 insertions(+), 5 deletions(-)
Signature · 1 line
2.35.1