Skip to content

leds: deduplicate led_init_default_state_get()

Andy Shevchenko linux-arm-kernel linux-leds linux-mediatek lkml netdev 3 versions – Applied

Status from this message: Applied, thanks

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest11 patches 13 repliesApplied
  2. v311 patches 14 repliesSuperseded
  3. v211 patches 1 replySuperseded

Changes in v4 from the cover letter

- added tags to patches 4, 5, 6, and 7 (Florian, AngeloGioacchino)
- resent with Lee included in the Cc list (Lee)

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/11leds: add missing includes and forward declarations in leds.hinclude/linux/leds.h+8 -51 reply
2/11leds: Move led_init_default_state_get() to the global headerdrivers/leds/leds.h include/linux/leds.h+2 -11 reply
3/11leds: an30259a: Get rid of custom led_init_default_state_get()drivers/leds/leds-an30259a.c+4 -171 reply
4/11leds: bcm6328: Get rid of custom led_init_default_state_get()drivers/leds/leds-bcm6328.c+24 -251 reply
5/11leds: bcm6358: Get rid of custom led_init_default_state_get()drivers/leds/leds-bcm6358.c+16 -161 reply
6/11leds: mt6323: Get rid of custom led_init_default_state_get()drivers/leds/leds-mt6323.c+15 -151 reply
7/11leds: mt6360: Get rid of custom led_init_default_state_get()drivers/leds/flash/leds-mt6360.c+6 -321 reply
8/11leds: pca955x: Get rid of custom led_init_default_state_get()drivers/leds/leds-pca955x.c+6 -201 reply
9/11leds: pm8058: Get rid of custom led_init_default_state_get()drivers/leds/leds-pm8058.c+15 -141 reply
10/11leds: syscon: Get rid of custom led_init_default_state_get()drivers/leds/leds-syscon.c+23 -261 reply
11/11net: dsa: hellcreek: Get rid of custom led_init_default_state_get()drivers/net/dsa/hirschmann/hellcreek_ptp.c+24 -213 replies

Reviews trailers per patch

5 of 11 patches have a Reviewed-by or Acked-by.

PatchFlorian FainelliMatthias BruggerAngeloGioacchino Del RegnoKurt Kanzenbach
1/11
2/11
3/11
4/11R-b
5/11R-b
6/11R-b
7/11R-b R-b
8/11
9/11
10/11
11/11R-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v4 thread

Cover letter [PATCH v4 00/11] leds: deduplicate led_init_default_state_get()

There are several users of LED framework that reimplement the functionality of led_init_default_state_get(). In order to deduplicate them move the declaration to the global header (patch 2) and convert users (patche 3-11).

Changelog v4:
- added tags to patches 4, 5, 6, and 7 (Florian, AngeloGioacchino)
- resent with Lee included in the Cc list (Lee)

Changelog v3:
- added tag to patch 11 (Kurt)
- Cc'ed to Lee, who might help with LED subsystem maintenance

Changelog v2:
- added missed patch 2 and hence make it the series
- appended tag to patch 7
- new patch 1

Andy Shevchenko (11):
leds: add missing includes and forward declarations in leds.h
leds: Move led_init_default_state_get() to the global header
leds: an30259a: Get rid of custom led_init_default_state_get()
leds: bcm6328: Get rid of custom led_init_default_state_get()
leds: bcm6358: Get rid of custom led_init_default_state_get()
leds: mt6323: Get rid of custom led_init_default_state_get()
leds: mt6360: Get rid of custom led_init_default_state_get()
leds: pca955x: Get rid of custom led_init_default_state_get()
leds: pm8058: Get rid of custom led_init_default_state_get()
leds: syscon: Get rid of custom led_init_default_state_get()
net: dsa: hellcreek: Get rid of custom led_init_default_state_get()

 drivers/leds/flash/leds-mt6360.c           | 38 +++--------------
 drivers/leds/leds-an30259a.c               | 21 ++--------
 drivers/leds/leds-bcm6328.c                | 49 +++++++++++-----------
 drivers/leds/leds-bcm6358.c                | 32 +++++++-------
 drivers/leds/leds-mt6323.c                 | 30 ++++++-------
 drivers/leds/leds-pca955x.c                | 26 +++---------
 drivers/leds/leds-pm8058.c                 | 29 ++++++-------
 drivers/leds/leds-syscon.c                 | 49 ++++++++++------------
 drivers/leds/leds.h                        |  1 -
 drivers/net/dsa/hirschmann/hellcreek_ptp.c | 45 ++++++++++----------
 include/linux/leds.h                       | 15 ++++---
 11 files changed, 143 insertions(+), 192 deletions(-)
Signature · 1 line
2.35.1