RFC devlink: add policy check for all attributes
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest6 patches 4 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | mnlg: remove unnused mnlg_socket structuredevlink/ | +0 | 0 replies | |
| 2/6 | utils: extract CTRL_ATTR_MAXATTR and save itinclude/ lib/ | +13 | 0 replies | |
| 3/6 | mnl_utils: add function to dump command policyinclude/ lib/ | +267 | 0 replies | |
| 4/6 | devlink: use dl_no_arg instead of checking dl_argc == 0devlink/ | +16 | 0 replies | |
| 5/6 | devlink: remove dl_argv_parse_putdevlink/ | +317 | 0 replies | |
| 6/6 | devlink: check attributes against policydevlink/ | +347 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC iproute2 0/6] devlink: add policy check for all attributes
This series implements code to check the kernel policy for the devlink commands to determine whether or not attributes are supported before adding them to netlink messages.
It implements a new mnlu_gen_get_op_policy to extract the policy information, and uses it to implement checks when parsing option arguments. This is intended to eventually go along with improvements to the policy reporting in devlink kernel code to report separate policy for each command.
I think checking every attribute makes sense and is easier to follow than only checking specific attributes. This will help ensure that future attributes don't accidentally get sent to commands when they aren't supported (once the devlink kernel policy is improved to report correct information for each command separately).
Jacob Keller (6):
mnlg: remove unnused mnlg_socket structure
utils: extract CTRL_ATTR_MAXATTR and save it
mnl_utils: add function to dump command policy
devlink: use dl_no_arg instead of checking dl_argc == 0
devlink: remove dl_argv_parse_put
devlink: check attributes against policy
devlink/devlink.c | 846 ++++++++++++++++++++++++++++++-------------- devlink/mnlg.c | 8 - include/mnl_utils.h | 28 ++ lib/mnl_utils.c | 258 +++++++++++++- 4 files changed, 858 insertions(+), 282 deletions(-)
Signature · 1 line
2.37.1.208.ge72d93e88cb2