Skip to content

Don't reinit map value in prealloc_lru_pop

Kumar Kartikeya Dwivedi bpf 3 versions – Applied

Status from this message: This series was applied to bpf/bpf.git (master)

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest3 patches 4 repliesApplied 3/3
  2. v23 patches 5 repliesSuperseded
  3. v13 patches 10 repliesSuperseded

Changes in v3 from the cover letter

v2: https://lore.kernel.org/bpf/[email protected]

* Switch test to use kptr instead of kptr_ref to stabilize test runs
* Fix missing lru_bug__destroy (Yonghong)
* Collect Acks

Patches in v3 All 3 applied

#Subject and filesSizeRepliesApplied
1/3bpf: Allow calling bpf_prog_test kfuncs in tracing programsnet/bpf/test_run.c+1 -00 repliesApplied
2/3bpf: Don't reinit map value in prealloc_lru_popkernel/bpf/hashtab.c+1 -54 repliesApplied
3/3selftests/bpf: Add test for prealloc_lru_pop bugtools/testing/selftests/bpf/prog_tests/lru_bug.c tools/testing/selftests/bpf/progs/lru_bug.c+70 -00 repliesApplied

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by.

PatchYonghong SongMartin KaFai Lau
1/3A-b
2/3A-b A-b
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v3 thread

Cover letter [PATCH bpf v3 0/3] Don't reinit map value in prealloc_lru_pop

Fix for a bug in prealloc_lru_pop spotted while reading the code, then a test + example that checks whether it is fixed.

Changelog:
----------
v2 -> v3:
v2: https://lore.kernel.org/bpf/[email protected]

* Switch test to use kptr instead of kptr_ref to stabilize test runs
* Fix missing lru_bug__destroy (Yonghong)
* Collect Acks

v1 -> v2:
v1: https://lore.kernel.org/bpf/[email protected]

* Expand commit log to include summary of the discussion with Yonghong
* Make lru_bug selftest serial to not mess up refcount for map_kptr test

Kumar Kartikeya Dwivedi (3):
bpf: Allow calling bpf_prog_test kfuncs in tracing programs
bpf: Don't reinit map value in prealloc_lru_pop selftests/bpf: Add test for prealloc_lru_pop bug

 kernel/bpf/hashtab.c                          |  6 +--
 net/bpf/test_run.c                            |  1 +
 .../selftests/bpf/prog_tests/lru_bug.c        | 21 ++++++++
 tools/testing/selftests/bpf/progs/lru_bug.c   | 49 +++++++++++++++++++
 4 files changed, 72 insertions(+), 5 deletions(-)
 create mode 100644 tools/testing/selftests/bpf/prog_tests/lru_bug.c
 create mode 100644 tools/testing/selftests/bpf/progs/lru_bug.c
Signature · 1 line
2.34.1