Skip to content

virtio-blk and scsi: replace dataplane_{start/stopping/started}

Emanuele Giuseppe Esposito qemu-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2virtio-scsi: replace VirtIOBlock dataplane_{start/starting/stopped} with enumhw/scsi/virtio-scsi-dataplane.c hw/scsi/virtio-scsi.c include/hw/virtio/virtio-scsi.h +1 more+24 -191 reply
2/2virtio-blk: replace dataplane_start/stopping/started with enumhw/block/dataplane/virtio-blk.c hw/block/virtio-blk.c include/hw/virtio/virtio-blk.h+15 -201 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] virtio-blk and scsi: replace dataplane_{start/stopping/started}

The way the dataplane stages at startup and stop are monitored is unnecessary complicated. In virtio-scsi we have dataplane_started, dataplane_starting and dataplane_stopping in VirtIOSCSI.
In virtio-blk we have dataplene_started in VirtIOBlock, and starting and stopping in VirtIOBlockDataPlane.

Just replace all these flags with an atomic enum.

Based-on: [email protected]

Emanuele Giuseppe Esposito (2):
virtio-scsi: replace VirtIOBlock dataplane_{start/starting/stopped}
with enum
virtio-blk: replace dataplane_start/stopping/started with enum

 hw/block/dataplane/virtio-blk.c | 24 +++++++++---------------
 hw/block/virtio-blk.c           |  9 +++++----
 hw/scsi/virtio-scsi-dataplane.c | 21 +++++++++------------
 hw/scsi/virtio-scsi.c           | 10 ++++++----
 include/hw/virtio/virtio-blk.h  |  2 +-
 include/hw/virtio/virtio-scsi.h |  5 ++---
 include/hw/virtio/virtio.h      |  7 +++++++
 7 files changed, 39 insertions(+), 39 deletions(-)
Signature · 1 line
2.31.1