Skip to content

RFC zram: Allow rw_page when page isn't written back.

Brian Geffon linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest1 patch 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/1zram: Allow rw_page when page isn't written back.drivers/block/zram/zram_drv.c drivers/block/zram/zram_drv.h+41 -252 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/1] zram: Allow rw_page when page isn't written back.

Today when a zram device has a backing device we change the ops to a new set which does not expose a rw_page method. This prevents the upper layers from trying to issue a synchronous rw. This has the downside that we penalize every rw even when it could possibly still be performed as a synchronous rw.

This is just a proposal and I wanted to get feedback if people felt this was worthwhile.

The motivation comes from what Minchan noted in the original change which introduced the synchronous behavior that it enhanches swap-in performance by about 45% [1]. So it'd be great if we could still get this benefit while using writeback.

1. https://lore.kernel.org/all/[email protected]/

Brian Geffon (1):
zram: Allow rw_page when page isn't written back.

 drivers/block/zram/zram_drv.c | 65 +++++++++++++++++++++--------------
 drivers/block/zram/zram_drv.h |  1 +
 2 files changed, 41 insertions(+), 25 deletions(-)
Signature · 1 line
2.37.1.559.g78731f0fdb-goog