Skip to content

tpm: Pull tpm_tis_phy_ops and tpm_tis_i2c updates

Peter Delevoryas openbmc 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Revert "tpm: tpm_tis: Add tpm_tis_i2c driver"drivers/char/tpm/Kconfig drivers/char/tpm/Makefile drivers/char/tpm/tpm_tis_i2c.c+0 -2760 replies
2/7tpm: Remove read16/read32/write32 calls from tpm_tis_phy_opsdrivers/char/tpm/tpm_tis.c drivers/char/tpm/tpm_tis_core.h drivers/char/tpm/tpm_tis_spi.h +3 more+118 -1610 replies
3/7dt-bindings: trivial-devices: Add Infineon SLB9673 TPMDocumentation/devicetree/bindings/trivial-devices.yaml+2 -00 replies
4/7tpm: Add tpm_tis_verify_crc to the tpm_tis_phy_ops protocol layerdrivers/char/tpm/tpm_tis_core.c drivers/char/tpm/tpm_tis_core.h+24 -00 replies
5/7tpm: Add tpm_tis_i2c backend for tpm_tis_coredrivers/char/tpm/Kconfig drivers/char/tpm/Makefile drivers/char/tpm/tpm_tis_i2c.c+404 -00 replies
6/7tpm: fix platform_no_drv_owner.cocci warningdrivers/char/tpm/tpm_tis_i2c.c+0 -10 replies
7/7tpm_tis_i2c: Add old compatible strings backdrivers/char/tpm/tpm_tis_i2c.c+2 -00 replies

Reviews trailers per patch

5 of 7 patches have a Reviewed-by or Acked-by.

PatchRob HerringJarkko Sakkinen
1/7
2/7R-b
3/7A-b R-b
4/7R-b
5/7R-b
6/7R-b
7/7

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/7] tpm: Pull tpm_tis_phy_ops and tpm_tis_i2c updates

OpenBMC's Linux dev-5.15 has an old tpm_tis_i2c driver from Nuvoton, but it was never merged upstreamed and produces compilation warnings now.

Infineon took that driver, modified it, and merged it upstream. Nuvoton never merged theirs, so the first patch in this series reverts theirs.

Also, I included the "Remove read16, read32, write32" patch because otherwise Alexander's patches don't apply cleanly. But, I could actually resolve the merge conflicts. I figured it will be easier later to just include more patches from upstream to make it clean.

I also noticed there was one follow-up change submitted by alibaba to remove one line, so I included that.

Alexander didn't include the compatible strings from the old driver, even though it should be compatible, so I've included a patch at the end which fixes that. I did it as a separate patch so that we maintain a patch series closer to what the upstream will be.

cc'ing Alexander on this thread too to see if he has any suggestions, or thinks I missed anything.

I haven't cc'd the linux kernel mailing list aliases because I don't think this is relevant to them. Only the patch including the compatible strings will be relevant.

checkpath.pl warns agains MAINTAINERS, but I'm pretty sure it's fine. The upstream MAINTAINERS file hasn't been updated with these changes, so we probably don't need to do anything there.

This was a follow-up from the following OpenBMC mailing list thread:

https://lore.kernel.org/openbmc/[email protected]/

Thanks,
Peter

Alexander Steffen (3):
dt-bindings: trivial-devices: Add Infineon SLB9673 TPM
tpm: Add tpm_tis_verify_crc to the tpm_tis_phy_ops protocol layer
tpm: Add tpm_tis_i2c backend for tpm_tis_core

Johannes Holland (1):
tpm: Remove read16/read32/write32 calls from tpm_tis_phy_ops

Peter Delevoryas (2):
Revert "tpm: tpm_tis: Add tpm_tis_i2c driver"
tpm_tis_i2c: Add old compatible strings back

Yang Li (1):
tpm: fix platform_no_drv_owner.cocci warning

 .../devicetree/bindings/trivial-devices.yaml  |   2 +
 drivers/char/tpm/Kconfig                      |  24 +-
 drivers/char/tpm/tpm_tis.c                    |  67 ++-
 drivers/char/tpm/tpm_tis_core.c               |  14 +
 drivers/char/tpm/tpm_tis_core.h               |  68 ++-
 drivers/char/tpm/tpm_tis_i2c.c                | 431 ++++++++++++------
 drivers/char/tpm/tpm_tis_spi.h                |   4 -
 drivers/char/tpm/tpm_tis_spi_cr50.c           |   7 +-
 drivers/char/tpm/tpm_tis_spi_main.c           |  45 +-
 drivers/char/tpm/tpm_tis_synquacer.c          |  98 ++--
 10 files changed, 436 insertions(+), 324 deletions(-)
Signature · 1 line
2.37.1