Skip to content

netfilter: conntrack: remove 64kb max size assumptions

Florian Westphal netfilter-devel 1 version Applied

Status from this message: Applied, thanks.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 5 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/4netfilter: conntrack: sane: remove pseudo skb linearizationnet/netfilter/nf_conntrack_sane.c+30 -380 replies
2/4netfilter: conntrack: h323: cap packet size at 64knet/netfilter/nf_conntrack_h323_main.c+9 -10 replies
3/4netfilter: conntrack_ftp: prefer skb_linearizenet/netfilter/nf_conntrack_ftp.c+6 -184 replies
4/4netfilter: conntrack_irc: cap packet search space to 4knet/netfilter/nf_conntrack_irc.c+9 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH nf 0/4] netfilter: conntrack: remove 64kb max size assumptions

Some of our dated conntrack helpers assume skbs can't contain tcp packets larger than 64kb.

Update those. For SANE, I don't see a reason for the 'full-packet-copy', just extract the sane header.

For h323, packet gets capped at 64k; larger one will be seen as truncated.

For irc, cap at 4k: a line length should not exceed 512 bytes. For ftp, use skb_linearize(), its the most simple way to resolve this.

Florian Westphal (4):
netfilter: conntrack: sane: remove pseudo skb linearization
netfilter: conntrack: h323: cap packet size at 64k
netfilter: conntrack_ftp: prefer skb_linearize
netfilter: conntrack_irc: cap packet search space to 4k

 net/netfilter/nf_conntrack_ftp.c       | 24 +++------
 net/netfilter/nf_conntrack_h323_main.c | 10 +++-
 net/netfilter/nf_conntrack_irc.c       | 12 +++--
 net/netfilter/nf_conntrack_sane.c      | 68 ++++++++++++--------------
 4 files changed, 54 insertions(+), 60 deletions(-)
Signature · 1 line
2.35.1